threads / patch / 16277

patchgit-submodule: Avoid printing a spurious message.

Subject: [PATCH] git-submodule: Avoid printing a spurious message.

## tl;dr

3 messages between Nov 11, 2008 and Nov 12, 2008. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Alexandre Julliard· Nov 11, 2008, 21:09 UTC · lore

Fix 'git submodule update' to avoid printing a spurious "Maybe you want to use 'update --init'?" once for every uninitialized submodule it encounters.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
---
 git-submodule.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to git-submodule.sh +1 −1
diff --git a/git-submodule.sh b/git-submodule.sh
index b63e5c3..220d94e 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -323,7 +323,7 @@ cmd_update()
 			# Only mention uninitialized submodules when its
 			# path have been specified
 			test "$#" != "0" &&
-			say "Submodule path '$path' not initialized"
+			say "Submodule path '$path' not initialized" &&
 			say "Maybe you want to use 'update --init'?"
 			continue
 		fi
-- 
1.6.0.4.637.ga2ff4

-- 
Alexandre Julliard
julliard@winehq.org
Johannes Schindelin· Nov 12, 2008, 00:07 UTC · re: Alexandre Julliard · lore

Re: [PATCH] git-submodule: Avoid printing a spurious message.

Hi,
On Tue, 11 Nov 2008, Alexandre Julliard wrote:
Show 22 quoted lines
> Fix 'git submodule update' to avoid printing a spurious "Maybe you want
> to use 'update --init'?" once for every uninitialized submodule it
> encounters.
> 
> Signed-off-by: Alexandre Julliard <julliard@winehq.org>
> ---
>  git-submodule.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/git-submodule.sh b/git-submodule.sh
> index b63e5c3..220d94e 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -323,7 +323,7 @@ cmd_update()
>  			# Only mention uninitialized submodules when its
>  			# path have been specified
>  			test "$#" != "0" &&
> -			say "Submodule path '$path' not initialized"
> +			say "Submodule path '$path' not initialized" &&
>  			say "Maybe you want to use 'update --init'?"
>  			continue
>  		fi
Ooops, thanks (& ACK).

Ciao, Dscho

← back to recent threads