# [PATCH] git-submodule: Avoid printing a spurious message.

3 messages from 2008-11-11 to 2008-11-12. Participants: Alexandre Julliard, Johannes Schindelin, Junio C Hamano.
Thread: https://gitlist.dev/t/16277

## Alexandre Julliard, 2008-11-11 21:09

Subject: [PATCH] git-submodule: Avoid printing a spurious message.
Message-ID: <87myg67ywz.fsf@wine.dyndns.org>
URL: https://gitlist.dev/e/87myg67ywz.fsf%40wine.dyndns.org

```
Fix 'git submodule update' to avoid printing a spurious "Maybe you want
to use 'update --init'?" once for every uninitialized submodule it
encounters.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
---
 git-submodule.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-submodule.sh b/git-submodule.sh
index b63e5c3..220d94e 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -323,7 +323,7 @@ cmd_update()
 			# Only mention uninitialized submodules when its
 			# path have been specified
 			test "$#" != "0" &&
-			say "Submodule path '$path' not initialized"
+			say "Submodule path '$path' not initialized" &&
 			say "Maybe you want to use 'update --init'?"
 			continue
 		fi
-- 
1.6.0.4.637.ga2ff4

-- 
Alexandre Julliard
julliard@winehq.org

```

## Johannes Schindelin, 2008-11-12 00:07

Subject: Re: [PATCH] git-submodule: Avoid printing a spurious message.
Message-ID: <alpine.DEB.1.00.0811120107240.30769@pacific.mpi-cbg.de>
URL: https://gitlist.dev/e/alpine.DEB.1.00.0811120107240.30769%40pacific.mpi-cbg.de
In-Reply-To: <87myg67ywz.fsf@wine.dyndns.org>

```
Hi,

On Tue, 11 Nov 2008, Alexandre Julliard wrote:

> Fix 'git submodule update' to avoid printing a spurious "Maybe you want
> to use 'update --init'?" once for every uninitialized submodule it
> encounters.
> 
> Signed-off-by: Alexandre Julliard <julliard@winehq.org>
> ---
>  git-submodule.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/git-submodule.sh b/git-submodule.sh
> index b63e5c3..220d94e 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -323,7 +323,7 @@ cmd_update()
>  			# Only mention uninitialized submodules when its
>  			# path have been specified
>  			test "$#" != "0" &&
> -			say "Submodule path '$path' not initialized"
> +			say "Submodule path '$path' not initialized" &&
>  			say "Maybe you want to use 'update --init'?"
>  			continue
>  		fi

Ooops, thanks (& ACK).

Ciao,
Dscho

```

## Junio C Hamano, 2008-11-12 00:51

Subject: Re: [PATCH] git-submodule: Avoid printing a spurious message.
Message-ID: <7vod0lu5pq.fsf@gitster.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vod0lu5pq.fsf%40gitster.siamese.dyndns.org
In-Reply-To: <87myg67ywz.fsf@wine.dyndns.org>

```
Good eyes, thanks.  Will apply to 'maint'.

```