threads / discuss / 1599

patchSubject: [PATCH] Fix git-commit-script to output on stderr when -v fails

Subject: Subject: [PATCH] Fix git-commit-script to output on stderr when -v fails

## tl;dr

One message between Aug 20, 2005 and Aug 20, 2005. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Marco Costalba· Aug 20, 2005, 16:07 UTC · lore
From: Marco Costalba <mcostalba@yahoo.it>
Date: 1124553736 +0200

When git-commit-script is called with -v option and verify test fails result is print on stdout instead of stderr.

Signed-off-by: Marco Costalba <mcostalba@yahoo.it>
---
 git-commit-script |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
676a1dcf50a5abc3bc9751c9dbb0146ae31ebfc9
Show changes to git-commit-script +5 −5
diff --git a/git-commit-script b/git-commit-script
--- a/git-commit-script
+++ b/git-commit-script
@@ -113,16 +113,16 @@ t)
 	    sub bad_line {
 		my ($why, $line) = @_;
 		if (!$found_bad) {
-		    print "*\n";
-		    print "* You have some suspicious patch lines:\n";
-		    print "*\n";
+		    print STDERR "*\n";
+		    print STDERR "* You have some suspicious patch lines:\n";
+		    print STDERR "*\n";
 		    $found_bad = 1;
 		}
 		if ($reported_filename ne $filename) {
-		    print "* In $filename\n";
+		    print STDERR "* In $filename\n";
 		    $reported_filename = $filename;
 		}
-		print "* $why (line $lineno)\n$line\n";
+		print STDERR "* $why (line $lineno)\n$line\n";
 	    }
 	    open $fh, "-|", qw(git-diff-cache -p -M --cached HEAD);
 	    while (<$fh>) {



__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

← back to recent threads