{"thread":{"id":"1599","subject":"Subject: [PATCH] Fix git-commit-script to output on stderr when -v fails","startedAt":"2005-08-20T16:07:15Z","lastAt":"2005-08-20T16:07:15Z","messageCount":1,"participants":["Marco Costalba"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"7586","messageId":"20050820160715.37321.qmail@web26309.mail.ukl.yahoo.com","threadId":"1599","inReplyTo":null,"subject":"Subject: [PATCH] Fix git-commit-script to output on stderr when -v fails","fromName":"Marco Costalba","fromEmail":"mcostalba@yahoo.it","sentAt":"2005-08-20T16:07:15Z","receivedAt":"2005-08-20T16:07:15Z","isPatch":true,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"From: Marco Costalba <mcostalba@yahoo.it>\nDate: 1124553736 +0200\n\nWhen git-commit-script is called with -v option and\nverify test fails result is print on stdout\ninstead of stderr.\n\nSigned-off-by: Marco Costalba <mcostalba@yahoo.it>\n\n---\n\n git-commit-script |   10 +++++-----\n 1 files changed, 5 insertions(+), 5 deletions(-)\n\n676a1dcf50a5abc3bc9751c9dbb0146ae31ebfc9\ndiff --git a/git-commit-script b/git-commit-script\n--- a/git-commit-script\n+++ b/git-commit-script\n@@ -113,16 +113,16 @@ t)\n \t    sub bad_line {\n \t\tmy ($why, $line) = @_;\n \t\tif (!$found_bad) {\n-\t\t    print \"*\\n\";\n-\t\t    print \"* You have some suspicious patch lines:\\n\";\n-\t\t    print \"*\\n\";\n+\t\t    print STDERR \"*\\n\";\n+\t\t    print STDERR \"* You have some suspicious patch lines:\\n\";\n+\t\t    print STDERR \"*\\n\";\n \t\t    $found_bad = 1;\n \t\t}\n \t\tif ($reported_filename ne $filename) {\n-\t\t    print \"* In $filename\\n\";\n+\t\t    print STDERR \"* In $filename\\n\";\n \t\t    $reported_filename = $filename;\n \t\t}\n-\t\tprint \"* $why (line $lineno)\\n$line\\n\";\n+\t\tprint STDERR \"* $why (line $lineno)\\n$line\\n\";\n \t    }\n \t    open $fh, \"-|\", qw(git-diff-cache -p -M --cached HEAD);\n \t    while (<$fh>) {\n\n\n\n__________________________________________________\nDo You Yahoo!?\nTired of spam?  Yahoo! Mail has the best spam protection around \nhttp://mail.yahoo.com \n"}]}