threads / discuss / 15729

[GUILT] Use git_editor

Subject: [GUILT] Use git_editor

## tl;dr

5 messages between Sep 30, 2008 and Oct 1, 2008.

replies: 4people: 2as markdown or json

Alan Jenkins· Sep 30, 2008, 18:43 UTC · lore

Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>

diff --git a/guilt b/guilt
index 1cef7b9..8d023e9 100755
--- a/guilt
+++ b/guilt
@@ -693,10 +693,6 @@ fi
 series="$GUILT_DIR/$branch/series"
 applied="$GUILT_DIR/$branch/status"
 
-# determine an editor to use for anything interactive (fall back to vi)
-editor="vi"
-[ ! -z "$EDITOR" ] && editor="$EDITOR"
-
 # determine a pager to use for anything interactive (fall back to more)
 pager="more"
 [ ! -z "$PAGER" ] && pager="$PAGER"
diff --git a/guilt-header b/guilt-header
index da46c82..66521ac 100755
--- a/guilt-header
+++ b/guilt-header
@@ -46,7 +46,7 @@ if [ -z "$edit" ]; then
 else
 	do_get_full_header "$GUILT_DIR/$branch/$patch" > "$TMP_MSG"
 	do_get_patch "$GUILT_DIR/$branch/$patch" > "$TMP_DIFF"
-	$editor "$TMP_MSG"
+	git_editor "$TMP_MSG"
 	mv "$GUILT_DIR/$branch/$patch" "$GUILT_DIR/$branch/$patch~"
 
 	(
diff --git a/guilt-new b/guilt-new
index 05318a5..7845d00 100755
--- a/guilt-new
+++ b/guilt-new
@@ -77,7 +77,7 @@ mkdir_dir=`dirname "$GUILT_DIR/$branch/$patch"`
 ) >> "$GUILT_DIR/$branch/$patch"
 
 # edit -e ?
-[ "$edit" = "t" ] && $editor "$GUILT_DIR/$branch/$patch"
+[ "$edit" = "t" ] && git_editor "$GUILT_DIR/$branch/$patch"
 
 if [ ! -z "$force" ]; then
 	(
diff --git a/guilt-series b/guilt-series
index 7d8f8e9..4f24ffd 100755
--- a/guilt-series
+++ b/guilt-series
@@ -22,7 +22,7 @@ do
 done
 
 if [ ! -z "$edit" ]; then 
-	$editor "$series"
+	git_editor "$series"
 elif [ ! -z "$gui" ]; then
 	[ -z "`get_top`" ] && die "No patches applied."
 	bottom=`git rev-parse refs/patches/$branch/$(head -1 $applied)`

Josef 'Jeff' Sipek· Sep 30, 2008, 19:07 UTC · re: Alan Jenkins · lore

Re: [GUILT] Use git_editor

On Tue, Sep 30, 2008 at 07:43:50PM +0100, Alan Jenkins wrote:

Show 14 quoted lines

> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
> 
> diff --git a/guilt b/guilt
> index 1cef7b9..8d023e9 100755
> --- a/guilt
> +++ b/guilt
> @@ -693,10 +693,6 @@ fi
>  series="$GUILT_DIR/$branch/series"
>  applied="$GUILT_DIR/$branch/status"
>  
> -# determine an editor to use for anything interactive (fall back to vi)
> -editor="vi"
> -[ ! -z "$EDITOR" ] && editor="$EDITOR"
> -

Looks good from a quick glance. Any chance there's a git_pager?

Josef 'Jeff' Sipek.

-- 
Bad pun of the week: The formula 1 control computer suffered from a race
condition

Alan Jenkins· Sep 30, 2008, 19:14 UTC · re: Josef 'Jeff' Sipek · lore

Re: [GUILT] Use git_editor

Josef 'Jeff' Sipek wrote:

Show 22 quoted lines

> On Tue, Sep 30, 2008 at 07:43:50PM +0100, Alan Jenkins wrote:
>   
>> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
>>
>> diff --git a/guilt b/guilt
>> index 1cef7b9..8d023e9 100755
>> --- a/guilt
>> +++ b/guilt
>> @@ -693,10 +693,6 @@ fi
>>  series="$GUILT_DIR/$branch/series"
>>  applied="$GUILT_DIR/$branch/status"
>>  
>> -# determine an editor to use for anything interactive (fall back to vi)
>> -editor="vi"
>> -[ ! -z "$EDITOR" ] && editor="$EDITOR"
>> -
>>     
>
> Looks good from a quick glance. Any chance there's a git_pager?
>
> Josef 'Jeff' Sipek.
>

Not in git-sh-setup.  I did check :-).

Alan

Josef 'Jeff' Sipek· Sep 30, 2008, 20:22 UTC · re: Alan Jenkins · lore

Re: [GUILT] Use git_editor

On Tue, Sep 30, 2008 at 08:14:15PM +0100, Alan Jenkins wrote:

Show 24 quoted lines

> Josef 'Jeff' Sipek wrote:
> > On Tue, Sep 30, 2008 at 07:43:50PM +0100, Alan Jenkins wrote:
> >   
> >> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
> >>
> >> diff --git a/guilt b/guilt
> >> index 1cef7b9..8d023e9 100755
> >> --- a/guilt
> >> +++ b/guilt
> >> @@ -693,10 +693,6 @@ fi
> >>  series="$GUILT_DIR/$branch/series"
> >>  applied="$GUILT_DIR/$branch/status"
> >>  
> >> -# determine an editor to use for anything interactive (fall back to vi)
> >> -editor="vi"
> >> -[ ! -z "$EDITOR" ] && editor="$EDITOR"
> >> -
> >>     
> >
> > Looks good from a quick glance. Any chance there's a git_pager?
> >
> > Josef 'Jeff' Sipek.
> 
> Not in git-sh-setup.  I did check :-).

Interesting! There are definitely places in git that invoke _a_ pager...maybe there's a patch to git that need creating :)

Josef 'Jeff' Sipek.

-- 
Failure is not an option,
It comes bundled with your Microsoft product.

Josef 'Jeff' Sipek· Oct 1, 2008, 02:31 UTC · re: Alan Jenkins · lore

Re: [GUILT] Use git_editor

On Tue, Sep 30, 2008 at 07:43:50PM +0100, Alan Jenkins wrote:

> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>

Applied.

Thanks,

Josef 'Jeff' Sipek.

-- 
Don't drink and derive. Alcohol and algebra don't mix.