{"thread":{"id":"15729","subject":"[GUILT] Use git_editor","startedAt":"2008-09-30T18:43:50Z","lastAt":"2008-10-01T02:31:47Z","messageCount":5,"participants":["Alan Jenkins","Josef 'Jeff' Sipek"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"91968","messageId":"48E27366.3080503@tuffmail.co.uk","threadId":"15729","inReplyTo":null,"subject":"[GUILT] Use git_editor","fromName":"Alan Jenkins","fromEmail":"alan-jenkins@tuffmail.co.uk","sentAt":"2008-09-30T18:43:50Z","receivedAt":"2008-09-30T18:43:50Z","isPatch":false,"sender":{"key":"alan-jenkins@tuffmail.co.uk","avatar":null},"body":"Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>\n\ndiff --git a/guilt b/guilt\nindex 1cef7b9..8d023e9 100755\n--- a/guilt\n+++ b/guilt\n@@ -693,10 +693,6 @@ fi\n series=\"$GUILT_DIR/$branch/series\"\n applied=\"$GUILT_DIR/$branch/status\"\n \n-# determine an editor to use for anything interactive (fall back to vi)\n-editor=\"vi\"\n-[ ! -z \"$EDITOR\" ] && editor=\"$EDITOR\"\n-\n # determine a pager to use for anything interactive (fall back to more)\n pager=\"more\"\n [ ! -z \"$PAGER\" ] && pager=\"$PAGER\"\ndiff --git a/guilt-header b/guilt-header\nindex da46c82..66521ac 100755\n--- a/guilt-header\n+++ b/guilt-header\n@@ -46,7 +46,7 @@ if [ -z \"$edit\" ]; then\n else\n \tdo_get_full_header \"$GUILT_DIR/$branch/$patch\" > \"$TMP_MSG\"\n \tdo_get_patch \"$GUILT_DIR/$branch/$patch\" > \"$TMP_DIFF\"\n-\t$editor \"$TMP_MSG\"\n+\tgit_editor \"$TMP_MSG\"\n \tmv \"$GUILT_DIR/$branch/$patch\" \"$GUILT_DIR/$branch/$patch~\"\n \n \t(\ndiff --git a/guilt-new b/guilt-new\nindex 05318a5..7845d00 100755\n--- a/guilt-new\n+++ b/guilt-new\n@@ -77,7 +77,7 @@ mkdir_dir=`dirname \"$GUILT_DIR/$branch/$patch\"`\n ) >> \"$GUILT_DIR/$branch/$patch\"\n \n # edit -e ?\n-[ \"$edit\" = \"t\" ] && $editor \"$GUILT_DIR/$branch/$patch\"\n+[ \"$edit\" = \"t\" ] && git_editor \"$GUILT_DIR/$branch/$patch\"\n \n if [ ! -z \"$force\" ]; then\n \t(\ndiff --git a/guilt-series b/guilt-series\nindex 7d8f8e9..4f24ffd 100755\n--- a/guilt-series\n+++ b/guilt-series\n@@ -22,7 +22,7 @@ do\n done\n \n if [ ! -z \"$edit\" ]; then \n-\t$editor \"$series\"\n+\tgit_editor \"$series\"\n elif [ ! -z \"$gui\" ]; then\n \t[ -z \"`get_top`\" ] && die \"No patches applied.\"\n \tbottom=`git rev-parse refs/patches/$branch/$(head -1 $applied)`\n"},{"id":"91971","messageId":"20080930190744.GO32444@josefsipek.net","threadId":"15729","inReplyTo":"48E27366.3080503@tuffmail.co.uk","subject":"Re: [GUILT] Use git_editor","fromName":"Josef 'Jeff' Sipek","fromEmail":"jeffpc@josefsipek.net","sentAt":"2008-09-30T19:07:44Z","receivedAt":"2008-09-30T19:07:44Z","isPatch":false,"sender":{"key":"jeffpc@josefsipek.net","avatar":null},"body":"On Tue, Sep 30, 2008 at 07:43:50PM +0100, Alan Jenkins wrote:\n> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>\n> \n> diff --git a/guilt b/guilt\n> index 1cef7b9..8d023e9 100755\n> --- a/guilt\n> +++ b/guilt\n> @@ -693,10 +693,6 @@ fi\n>  series=\"$GUILT_DIR/$branch/series\"\n>  applied=\"$GUILT_DIR/$branch/status\"\n>  \n> -# determine an editor to use for anything interactive (fall back to vi)\n> -editor=\"vi\"\n> -[ ! -z \"$EDITOR\" ] && editor=\"$EDITOR\"\n> -\n\nLooks good from a quick glance. Any chance there's a git_pager?\n\nJosef 'Jeff' Sipek.\n\n-- \nBad pun of the week: The formula 1 control computer suffered from a race\ncondition\n"},{"id":"91973","messageId":"48E27A87.9060205@tuffmail.co.uk","threadId":"15729","inReplyTo":"20080930190744.GO32444@josefsipek.net","subject":"Re: [GUILT] Use git_editor","fromName":"Alan Jenkins","fromEmail":"alan-jenkins@tuffmail.co.uk","sentAt":"2008-09-30T19:14:15Z","receivedAt":"2008-09-30T19:14:15Z","isPatch":false,"sender":{"key":"alan-jenkins@tuffmail.co.uk","avatar":null},"body":"Josef 'Jeff' Sipek wrote:\n> On Tue, Sep 30, 2008 at 07:43:50PM +0100, Alan Jenkins wrote:\n>   \n>> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>\n>>\n>> diff --git a/guilt b/guilt\n>> index 1cef7b9..8d023e9 100755\n>> --- a/guilt\n>> +++ b/guilt\n>> @@ -693,10 +693,6 @@ fi\n>>  series=\"$GUILT_DIR/$branch/series\"\n>>  applied=\"$GUILT_DIR/$branch/status\"\n>>  \n>> -# determine an editor to use for anything interactive (fall back to vi)\n>> -editor=\"vi\"\n>> -[ ! -z \"$EDITOR\" ] && editor=\"$EDITOR\"\n>> -\n>>     \n>\n> Looks good from a quick glance. Any chance there's a git_pager?\n>\n> Josef 'Jeff' Sipek.\n>   \n\nNot in git-sh-setup.  I did check :-).\n\nAlan\n"},{"id":"91982","messageId":"20080930202226.GP32444@josefsipek.net","threadId":"15729","inReplyTo":"48E27A87.9060205@tuffmail.co.uk","subject":"Re: [GUILT] Use git_editor","fromName":"Josef 'Jeff' Sipek","fromEmail":"jeffpc@josefsipek.net","sentAt":"2008-09-30T20:22:26Z","receivedAt":"2008-09-30T20:22:26Z","isPatch":false,"sender":{"key":"jeffpc@josefsipek.net","avatar":null},"body":"On Tue, Sep 30, 2008 at 08:14:15PM +0100, Alan Jenkins wrote:\n> Josef 'Jeff' Sipek wrote:\n> > On Tue, Sep 30, 2008 at 07:43:50PM +0100, Alan Jenkins wrote:\n> >   \n> >> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>\n> >>\n> >> diff --git a/guilt b/guilt\n> >> index 1cef7b9..8d023e9 100755\n> >> --- a/guilt\n> >> +++ b/guilt\n> >> @@ -693,10 +693,6 @@ fi\n> >>  series=\"$GUILT_DIR/$branch/series\"\n> >>  applied=\"$GUILT_DIR/$branch/status\"\n> >>  \n> >> -# determine an editor to use for anything interactive (fall back to vi)\n> >> -editor=\"vi\"\n> >> -[ ! -z \"$EDITOR\" ] && editor=\"$EDITOR\"\n> >> -\n> >>     \n> >\n> > Looks good from a quick glance. Any chance there's a git_pager?\n> >\n> > Josef 'Jeff' Sipek.\n> \n> Not in git-sh-setup.  I did check :-).\n\nInteresting! There are definitely places in git that invoke _a_\npager...maybe there's a patch to git that need creating :)\n\nJosef 'Jeff' Sipek.\n\n-- \nFailure is not an option,\nIt comes bundled with your Microsoft product.\n"},{"id":"92012","messageId":"20081001023147.GQ32444@josefsipek.net","threadId":"15729","inReplyTo":"48E27366.3080503@tuffmail.co.uk","subject":"Re: [GUILT] Use git_editor","fromName":"Josef 'Jeff' Sipek","fromEmail":"jeffpc@josefsipek.net","sentAt":"2008-10-01T02:31:47Z","receivedAt":"2008-10-01T02:31:47Z","isPatch":false,"sender":{"key":"jeffpc@josefsipek.net","avatar":null},"body":"On Tue, Sep 30, 2008 at 07:43:50PM +0100, Alan Jenkins wrote:\n> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>\n\nApplied.\n\nThanks,\n\nJosef 'Jeff' Sipek.\n\n-- \nDon't drink and derive. Alcohol and algebra don't mix.\n"}]}