threads / patch / 15483

patchcompletion: git commit should list --interactive

Subject: [PATCH] completion: git commit should list --interactive

## tl;dr

3 messages between Sep 11, 2008 and Sep 20, 2008. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Eric Raible· Sep 11, 2008, 00:40 UTC · lore

Signed-off-by: Eric Raible <raible@gmail.com>
---
 contrib/completion/git-completion.bash |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to contrib/completion/git-completion.bash +1 −1

diff --git a/contrib/completion/git-completion.bash
b/contrib/completion/git-completion.bash
index d3fb6ae..2d8d1c3 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -750,7 +750,7 @@ _git_commit ()
 	--*)
 		__gitcomp "
 			--all --author= --signoff --verify --no-verify
-			--edit --amend --include --only
+			--edit --amend --include --only --interactive
 			"
 		return
 	esac

-- 
1.6.0.1.436.g09e16c.dirty

Shawn O. Pearce· Sep 20, 2008, 01:16 UTC · re: Eric Raible · lore

Re: [PATCH] completion: git commit should list --interactive

Eric Raible <raible@gmail.com> wrote:

> Signed-off-by: Eric Raible <raible@gmail.com>
> ---
>  contrib/completion/git-completion.bash |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Trivally-Acked-by: Shawn O. Pearce <spearce@spearce.org>

Sorry, got backlogged at day-job. I'm kind of surprised this isn't in-tree yet, its pretty simple...

Show 16 quoted lines

> diff --git a/contrib/completion/git-completion.bash
> b/contrib/completion/git-completion.bash
> index d3fb6ae..2d8d1c3 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -750,7 +750,7 @@ _git_commit ()
>  	--*)
>  		__gitcomp "
>  			--all --author= --signoff --verify --no-verify
> -			--edit --amend --include --only
> +			--edit --amend --include --only --interactive
>  			"
>  		return
>  	esac
> -- 
> 1.6.0.1.436.g09e16c.dirty

-- 
Shawn.

Junio C Hamano· Sep 20, 2008, 02:44 UTC · re: Shawn O. Pearce · lore

Re: [PATCH] completion: git commit should list --interactive

"Shawn O. Pearce" <spearce@spearce.org> writes:

Show 10 quoted lines

> Eric Raible <raible@gmail.com> wrote:
>> Signed-off-by: Eric Raible <raible@gmail.com>
>> ---
>>  contrib/completion/git-completion.bash |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> Trivally-Acked-by: Shawn O. Pearce <spearce@spearce.org>
>
> Sorry, got backlogged at day-job.  I'm kind of surprised this isn't
> in-tree yet, its pretty simple...

Heh, I am kind of surprised this hasn't been Acked yet. IOW, you do not have monopoly on getting backlogged at dayjob.

Will apply, thanks both.