# [PATCH] completion: git commit should list --interactive

3 messages from 2008-09-11 to 2008-09-20. Participants: Eric Raible, Shawn O. Pearce, Junio C Hamano.
Thread: https://gitlist.dev/t/15483

## Eric Raible, 2008-09-11 00:40

Subject: [PATCH] completion: git commit should list --interactive
Message-ID: <279b37b20809101740v4a8f19b8k395208c124af0de0@mail.gmail.com>
URL: https://gitlist.dev/e/279b37b20809101740v4a8f19b8k395208c124af0de0%40mail.gmail.com

```
Signed-off-by: Eric Raible <raible@gmail.com>
---
 contrib/completion/git-completion.bash |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/contrib/completion/git-completion.bash
b/contrib/completion/git-completion.bash
index d3fb6ae..2d8d1c3 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -750,7 +750,7 @@ _git_commit ()
 	--*)
 		__gitcomp "
 			--all --author= --signoff --verify --no-verify
-			--edit --amend --include --only
+			--edit --amend --include --only --interactive
 			"
 		return
 	esac
-- 
1.6.0.1.436.g09e16c.dirty

```

## Shawn O. Pearce, 2008-09-20 01:16

Subject: Re: [PATCH] completion: git commit should list --interactive
Message-ID: <20080920011654.GI13139@spearce.org>
URL: https://gitlist.dev/e/20080920011654.GI13139%40spearce.org
In-Reply-To: <279b37b20809101740v4a8f19b8k395208c124af0de0@mail.gmail.com>

```
Eric Raible <raible@gmail.com> wrote:
> Signed-off-by: Eric Raible <raible@gmail.com>
> ---
>  contrib/completion/git-completion.bash |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Trivally-Acked-by: Shawn O. Pearce <spearce@spearce.org>

Sorry, got backlogged at day-job.  I'm kind of surprised this isn't
in-tree yet, its pretty simple...

> diff --git a/contrib/completion/git-completion.bash
> b/contrib/completion/git-completion.bash
> index d3fb6ae..2d8d1c3 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -750,7 +750,7 @@ _git_commit ()
>  	--*)
>  		__gitcomp "
>  			--all --author= --signoff --verify --no-verify
> -			--edit --amend --include --only
> +			--edit --amend --include --only --interactive
>  			"
>  		return
>  	esac
> -- 
> 1.6.0.1.436.g09e16c.dirty

-- 
Shawn.

```

## Junio C Hamano, 2008-09-20 02:44

Subject: Re: [PATCH] completion: git commit should list --interactive
Message-ID: <7vzlm35yff.fsf@gitster.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vzlm35yff.fsf%40gitster.siamese.dyndns.org
In-Reply-To: <20080920011654.GI13139@spearce.org>

```
"Shawn O. Pearce" <spearce@spearce.org> writes:

> Eric Raible <raible@gmail.com> wrote:
>> Signed-off-by: Eric Raible <raible@gmail.com>
>> ---
>>  contrib/completion/git-completion.bash |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> Trivally-Acked-by: Shawn O. Pearce <spearce@spearce.org>
>
> Sorry, got backlogged at day-job.  I'm kind of surprised this isn't
> in-tree yet, its pretty simple...

Heh, I am kind of surprised this hasn't been Acked yet.  IOW, you do not
have monopoly on getting backlogged at dayjob.

Will apply, thanks both.

```
