threads / patch / 14714

patchAllow building without any git installed

Subject: [PATCH] Allow building without any git installed

## tl;dr

2 messages between Jul 28, 2008 and Jul 28, 2008. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Junio C Hamano· Jul 28, 2008, 07:09 UTC · lore

This is a follow-up patch to 49fa65a (Allow the built-in exec path to be relative to the command invocation path, 2008-07-23). Without specific gitexecdir passed from the command line, git-gui's build procedure would try to figure out the value for it by running an installed git.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to Makefile +1 −1

diff --git a/Makefile b/Makefile
index 798a2f2..7e30b30 100644
--- a/Makefile
+++ b/Makefile
@@ -1067,7 +1067,7 @@ endif
 
 all::
 ifndef NO_TCLTK
-	$(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) all
+	$(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) gitexecdir='$(gitexec_instdir_SQ)' all
 	$(QUIET_SUBDIR0)gitk-git $(QUIET_SUBDIR1) all
 endif
 	$(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' all

-- 
1.6.0.rc1

Shawn O. Pearce· Jul 28, 2008, 13:50 UTC · re: Junio C Hamano · lore

Re: [PATCH] Allow building without any git installed

Junio C Hamano <gitster@pobox.com> wrote:

> This is a follow-up patch to 49fa65a (Allow the built-in exec path to be
> relative to the command invocation path, 2008-07-23).  Without specific
> gitexecdir passed from the command line, git-gui's build procedure would
> try to figure out the value for it by running an installed git.

Ack. I noticed this yesterday while looking at the git Makefile but forgot to send a patch for it myself. Thanks Junio.

Show 13 quoted lines

> diff --git a/Makefile b/Makefile
> index 798a2f2..7e30b30 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1067,7 +1067,7 @@ endif
>  
>  all::
>  ifndef NO_TCLTK
> -	$(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) all
> +	$(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) gitexecdir='$(gitexec_instdir_SQ)' all
>  	$(QUIET_SUBDIR0)gitk-git $(QUIET_SUBDIR1) all
>  endif
>  	$(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' all

-- 
Shawn.