{"thread":{"id":"14714","subject":"[PATCH] Allow building without any git installed","startedAt":"2008-07-28T07:09:26Z","lastAt":"2008-07-28T13:50:00Z","messageCount":2,"participants":["Junio C Hamano","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"85257","messageId":"7vsktutrh5.fsf@gitster.siamese.dyndns.org","threadId":"14714","inReplyTo":null,"subject":"[PATCH] Allow building without any git installed","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-07-28T07:09:26Z","receivedAt":"2008-07-28T07:09:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"This is a follow-up patch to 49fa65a (Allow the built-in exec path to be\nrelative to the command invocation path, 2008-07-23).  Without specific\ngitexecdir passed from the command line, git-gui's build procedure would\ntry to figure out the value for it by running an installed git.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 798a2f2..7e30b30 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1067,7 +1067,7 @@ endif\n \n all::\n ifndef NO_TCLTK\n-\t$(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) all\n+\t$(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) gitexecdir='$(gitexec_instdir_SQ)' all\n \t$(QUIET_SUBDIR0)gitk-git $(QUIET_SUBDIR1) all\n endif\n \t$(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' all\n-- \n1.6.0.rc1\n"},{"id":"85293","messageId":"20080728135000.GA3996@spearce.org","threadId":"14714","inReplyTo":"7vsktutrh5.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Allow building without any git installed","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-07-28T13:50:00Z","receivedAt":"2008-07-28T13:50:00Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Junio C Hamano <gitster@pobox.com> wrote:\n> This is a follow-up patch to 49fa65a (Allow the built-in exec path to be\n> relative to the command invocation path, 2008-07-23).  Without specific\n> gitexecdir passed from the command line, git-gui's build procedure would\n> try to figure out the value for it by running an installed git.\n\nAck.  I noticed this yesterday while looking at the git Makefile but\nforgot to send a patch for it myself.  Thanks Junio.\n\n \n> diff --git a/Makefile b/Makefile\n> index 798a2f2..7e30b30 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1067,7 +1067,7 @@ endif\n>  \n>  all::\n>  ifndef NO_TCLTK\n> -\t$(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) all\n> +\t$(QUIET_SUBDIR0)git-gui $(QUIET_SUBDIR1) gitexecdir='$(gitexec_instdir_SQ)' all\n>  \t$(QUIET_SUBDIR0)gitk-git $(QUIET_SUBDIR1) all\n>  endif\n>  \t$(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' all\n\n-- \nShawn.\n"}]}