threads / patch / 14202

patchavoid off-by-one error in run_upload_archive

Subject: [PATCH] avoid off-by-one error in run_upload_archive

## tl;dr

One message between Jun 28, 2008 and Jun 28, 2008. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Jochen Voss· Jun 28, 2008, 16:04 UTC · lore

Make sure that buf has enough space to store the trailing \0 of the command line argument, too.

Signed-off-by: Jochen Voss <voss@seehuhn.de>
---
 builtin-upload-archive.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to builtin-upload-archive.c +1 −1
diff --git a/builtin-upload-archive.c b/builtin-upload-archive.c
index 48ae09e..371400d 100644
--- a/builtin-upload-archive.c
+++ b/builtin-upload-archive.c
@@ -30,7 +30,7 @@ static int run_upload_archive(int argc, const char **argv, const char *prefix)
 	if (argc != 2)
 		usage(upload_archive_usage);
 
-	if (strlen(argv[1]) > sizeof(buf))
+	if (strlen(argv[1]) + 1 > sizeof(buf))
 		die("insanely long repository name");
 
 	strcpy(buf, argv[1]); /* enter-repo smudges its argument */
-- 
1.5.3.7

← back to recent threads