# [PATCH] avoid off-by-one error in run_upload_archive 1 messages from 2008-06-28 to 2008-06-28. Participants: Jochen Voss. Thread: https://gitlist.dev/t/14202 ## Jochen Voss, 2008-06-28 16:04 Subject: [PATCH] avoid off-by-one error in run_upload_archive Message-ID: <20080628160424.GA27915@seehuhn.de> URL: https://gitlist.dev/e/20080628160424.GA27915%40seehuhn.de ``` Make sure that buf has enough space to store the trailing \0 of the command line argument, too. Signed-off-by: Jochen Voss --- builtin-upload-archive.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin-upload-archive.c b/builtin-upload-archive.c index 48ae09e..371400d 100644 --- a/builtin-upload-archive.c +++ b/builtin-upload-archive.c @@ -30,7 +30,7 @@ static int run_upload_archive(int argc, const char **argv, const char *prefix) if (argc != 2) usage(upload_archive_usage); - if (strlen(argv[1]) > sizeof(buf)) + if (strlen(argv[1]) + 1 > sizeof(buf)) die("insanely long repository name"); strcpy(buf, argv[1]); /* enter-repo smudges its argument */ -- 1.5.3.7 ```