threads / discuss / 13984

(unknown)

Subject: (unknown)

## tl;dr

3 messages between Jun 16, 2008 and Jun 16, 2008.

replies: 2people: 2as markdown or json

amery@geeks.cl· Jun 16, 2008, 20:02 UTC · lore

>From 25cb047690dd6101527cdfa6198dd6a6f93bf095 Mon Sep 17 00:00:00 2001

From: Alejandro Mery <amery@geeks.cl>
Date: Mon, 16 Jun 2008 20:27:14 +0200
Subject: [PATCH] git-am: head -1 is obsolete and doesn't work on some new systems

http://www.opengroup.org/onlinepubs/009695399/utilities/head.html
---
 git-am.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-am.sh b/git-am.sh
index b48096e..797988f 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -421,7 +421,7 @@ do
 	else
 	    action=yes
 	fi
-	FIRSTLINE=$(head -1 "$dotest/final-commit")
+	FIRSTLINE=$(head -n1 "$dotest/final-commit")
 
 	if test $action = skip
 	then

-- 
1.5.4.3

Jakub Narebski· Jun 16, 2008, 20:26 UTC · re: amery@geeks.cl · lore

Re: [PATCH] git-am: head -1 is obsolete and doesn't work on some new systems

<amery@geeks.cl> writes:

> From 25cb047690dd6101527cdfa6198dd6a6f93bf095 Mon Sep 17 00:00:00 2001

This line is not needed (unless you use git-send-mail, or import patch as mbox to your MUA), and it should be removed.

> From: Alejandro Mery <amery@geeks.cl>
> Date: Mon, 16 Jun 2008 20:27:14 +0200
> Subject: [PATCH] git-am: head -1 is obsolete and doesn't work on some new systems

These headers should go as mailing list headers, which mean that your MUA should generate proper from (if it cannot, the From: would have to stay), and subject should go as email subject.

> http://www.opengroup.org/onlinepubs/009695399/utilities/head.html

We are not interested in theoretical POSIX compliance, see CodingGuidelines.

Patch lacks signoff line, per SubmittingPatches

: Signed-off-by: Alejandro Mery <amery@geeks.cl>

Show 14 quoted lines

> ---
>  git-am.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/git-am.sh b/git-am.sh
> index b48096e..797988f 100755
> --- a/git-am.sh
> +++ b/git-am.sh
> @@ -421,7 +421,7 @@ do
>  	else
>  	    action=yes
>  	fi
> -	FIRSTLINE=$(head -1 "$dotest/final-commit")
> +	FIRSTLINE=$(head -n1 "$dotest/final-commit")

For better portability it would be better use 'sed 1q' here instead.

: - FIRSTLINE=$(head -1 "$dotest/final-commit") : + FIRSTLINE=$(sed -e 1q "$dotest/final-commit")

Show 5 quoted lines

>  	if test $action = skip
>  	then
> -- 
> 1.5.4.3
>

-- 
Jakub Narebski
Poland
ShadeHawk on #git

Alejandro Mery· Jun 16, 2008, 20:43 UTC · re: Jakub Narebski · lore

Re: [PATCH] git-am: head -1 is obsolete and doesn't work on some new systems

Jakub Narebski wrote:

Show 14 quoted lines

> <amery@geeks.cl> writes:
> 
>> From 25cb047690dd6101527cdfa6198dd6a6f93bf095 Mon Sep 17 00:00:00 2001
> 
> This line is not needed (unless you use git-send-mail, or import patch
> as mbox to your MUA), and it should be removed.
> 
>> From: Alejandro Mery <amery@geeks.cl>
>> Date: Mon, 16 Jun 2008 20:27:14 +0200
>> Subject: [PATCH] git-am: head -1 is obsolete and doesn't work on some new systems
> 
> These headers should go as mailing list headers, which mean that your
> MUA should generate proper from (if it cannot, the From: would have to
> stay), and subject should go as email subject.

I'm really sorry about this, I was trying to send what git-format-patch generated using ubuntu's nullmailer, but it didn't work as expected (no git-send-email on this thing)

I'll have to fight more before sending another patch from here.

Alejandro Mery