{"thread":{"id":"13984","subject":"(unknown)","startedAt":"2008-06-16T20:02:24Z","lastAt":"2008-06-16T20:43:53Z","messageCount":3,"participants":["amery@geeks.cl","Jakub Narebski","Alejandro Mery"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"80062","messageId":"1213646544.908600.7895.nullmailer@rafaella.geeks.cl","threadId":"13984","inReplyTo":null,"subject":"(unknown)","fromName":"","fromEmail":"amery@geeks.cl","sentAt":"2008-06-16T20:02:24Z","receivedAt":"2008-06-16T20:02:24Z","isPatch":false,"sender":{"key":"amery@geeks.cl","avatar":"https://gravatar.com/avatar/d970331bf1ac3470522d61807b93272ed89720f9afbb683cd1a81ca91806d877?d=mp&s=160"},"body":">From 25cb047690dd6101527cdfa6198dd6a6f93bf095 Mon Sep 17 00:00:00 2001\nFrom: Alejandro Mery <amery@geeks.cl>\nDate: Mon, 16 Jun 2008 20:27:14 +0200\nSubject: [PATCH] git-am: head -1 is obsolete and doesn't work on some new systems\n\nhttp://www.opengroup.org/onlinepubs/009695399/utilities/head.html\n---\n git-am.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-am.sh b/git-am.sh\nindex b48096e..797988f 100755\n--- a/git-am.sh\n+++ b/git-am.sh\n@@ -421,7 +421,7 @@ do\n \telse\n \t    action=yes\n \tfi\n-\tFIRSTLINE=$(head -1 \"$dotest/final-commit\")\n+\tFIRSTLINE=$(head -n1 \"$dotest/final-commit\")\n \n \tif test $action = skip\n \tthen\n-- \n1.5.4.3\n"},{"id":"80067","messageId":"m3tzftnn28.fsf@localhost.localdomain","threadId":"13984","inReplyTo":"1213646544.908600.7895.nullmailer@rafaella.geeks.cl","subject":"Re: [PATCH] git-am: head -1 is obsolete and doesn't work on some new systems","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-06-16T20:26:42Z","receivedAt":"2008-06-16T20:26:42Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"<amery@geeks.cl> writes:\n\n> From 25cb047690dd6101527cdfa6198dd6a6f93bf095 Mon Sep 17 00:00:00 2001\n\nThis line is not needed (unless you use git-send-mail, or import patch\nas mbox to your MUA), and it should be removed.\n\n> From: Alejandro Mery <amery@geeks.cl>\n> Date: Mon, 16 Jun 2008 20:27:14 +0200\n> Subject: [PATCH] git-am: head -1 is obsolete and doesn't work on some new systems\n\nThese headers should go as mailing list headers, which mean that your\nMUA should generate proper from (if it cannot, the From: would have to\nstay), and subject should go as email subject.\n\n> http://www.opengroup.org/onlinepubs/009695399/utilities/head.html\n\nWe are not interested in theoretical POSIX compliance, see\nCodingGuidelines.\n\nPatch lacks signoff line, per SubmittingPatches\n\n: Signed-off-by: Alejandro Mery <amery@geeks.cl>\n\n> ---\n>  git-am.sh |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/git-am.sh b/git-am.sh\n> index b48096e..797988f 100755\n> --- a/git-am.sh\n> +++ b/git-am.sh\n> @@ -421,7 +421,7 @@ do\n>  \telse\n>  \t    action=yes\n>  \tfi\n> -\tFIRSTLINE=$(head -1 \"$dotest/final-commit\")\n> +\tFIRSTLINE=$(head -n1 \"$dotest/final-commit\")\n\nFor better portability it would be better use 'sed 1q' here instead.\n\n: -\tFIRSTLINE=$(head -1 \"$dotest/final-commit\")\n: +\tFIRSTLINE=$(sed -e 1q \"$dotest/final-commit\")\n\n\n>  \tif test $action = skip\n>  \tthen\n> -- \n> 1.5.4.3\n> \n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"80073","messageId":"4856D089.1050608@geeks.cl","threadId":"13984","inReplyTo":"m3tzftnn28.fsf@localhost.localdomain","subject":"Re: [PATCH] git-am: head -1 is obsolete and doesn't work on some new systems","fromName":"Alejandro Mery","fromEmail":"amery@geeks.cl","sentAt":"2008-06-16T20:43:53Z","receivedAt":"2008-06-16T20:43:53Z","isPatch":true,"sender":{"key":"amery@geeks.cl","avatar":"https://gravatar.com/avatar/d970331bf1ac3470522d61807b93272ed89720f9afbb683cd1a81ca91806d877?d=mp&s=160"},"body":"Jakub Narebski wrote:\n> <amery@geeks.cl> writes:\n> \n>> From 25cb047690dd6101527cdfa6198dd6a6f93bf095 Mon Sep 17 00:00:00 2001\n> \n> This line is not needed (unless you use git-send-mail, or import patch\n> as mbox to your MUA), and it should be removed.\n> \n>> From: Alejandro Mery <amery@geeks.cl>\n>> Date: Mon, 16 Jun 2008 20:27:14 +0200\n>> Subject: [PATCH] git-am: head -1 is obsolete and doesn't work on some new systems\n> \n> These headers should go as mailing list headers, which mean that your\n> MUA should generate proper from (if it cannot, the From: would have to\n> stay), and subject should go as email subject.\n\nI'm really sorry about this, I was trying to send what git-format-patch \ngenerated using ubuntu's nullmailer, but it didn't work as expected (no \ngit-send-email on this thing)\n\nI'll have to fight more before sending another patch from here.\n\nAlejandro Mery\n"}]}