threads / discuss / 13815

Patches for some OS's.

Subject: Patches for some OS's.

## tl;dr

5 messages between Jun 5, 2008 and Jun 5, 2008.

replies: 4people: 2as markdown or json

Boyd Lynn Gerber· Jun 5, 2008, 17:16 UTC · lore
Hello,
I have attached the patches necessary to use GIT on some Non Linux OS's.

-- Boyd Gerber <gerberb@zenez.com> ZENEZ 1042 East Fort Union #135, Midvale Utah 84047

*** git-compat-util.h.orig Sun May 25 23:59:01 2008
--- git-compat-util.h Mon May 26 13:02:43 2008
***************
*** 39,45 ****
  /* Approximation of the length of the decimal representation of this type. */
  #define decimal_length(x)	((int)(sizeof(x) * 2.56 + 0.5) + 1)
  
! #if !defined(__APPLE__) && !defined(__FreeBSD__)
  #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */
  #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */
  #endif
--- 39,45 ----
  /* Approximation of the length of the decimal representation of this type. */
  #define decimal_length(x)	((int)(sizeof(x) * 2.56 + 0.5) + 1)
  
! #if !defined(__APPLE__) && !defined(__FreeBSD__ ) && !defined(__USLC__) && !defined(_M_UNIX)
  #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */
  #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */
  #endif
***************
*** 89,94 ****
  #include <grp.h>
  #define _ALL_SOURCE 1
  #endif
  
  #ifndef NO_ICONV
  #include <iconv.h>
--- 89,98 ----
  #include <grp.h>
  #define _ALL_SOURCE 1
  #endif
+ #if defined(__USLC__)
+ #undef _XOPEN_SOURCE
+ #include <grp.h>
+ #endif
  
  #ifndef NO_ICONV
  #include <iconv.h>
***************
*** 206,211 ****
  #endif
  
  #ifdef FREAD_READS_DIRECTORIES
  #define fopen(a,b) git_fopen(a,b)
  extern FILE *git_fopen(const char*, const char*);
  #endif
--- 210,216 ----
  #endif
  
  #ifdef FREAD_READS_DIRECTORIES
+ #if !defined (__USLC__)
  #define fopen(a,b) git_fopen(a,b)
  extern FILE *git_fopen(const char*, const char*);
  #endif
***************
*** 208,213 ****
  #ifdef FREAD_READS_DIRECTORIES
  #define fopen(a,b) git_fopen(a,b)
  extern FILE *git_fopen(const char*, const char*);
  #endif
  
  #ifdef SNPRINTF_RETURNS_BOGUS
--- 213,219 ----
  #if !defined (__USLC__)
  #define fopen(a,b) git_fopen(a,b)
  extern FILE *git_fopen(const char*, const char*);
+ #endif
  #endif
  
  #ifdef SNPRINTF_RETURNS_BOGUS
*** Makefile.orig Sun May 25 23:59:01 2008
--- Makefile Mon May 26 11:33:07 2008
***************
*** 165,170 ****
  # CFLAGS and LDFLAGS are for the users to override from the command line.
  
  CFLAGS = -g -O2 -Wall
  LDFLAGS =
  ALL_CFLAGS = $(CFLAGS)
  ALL_LDFLAGS = $(LDFLAGS)
--- 165,184 ----
  # CFLAGS and LDFLAGS are for the users to override from the command line.
  
  CFLAGS = -g -O2 -Wall
+ ifeq ($(uname_S),SCO_SV)
+   ifeq ($(uname_R),3.2)
+ #    CFLAGS = -g -O2
+     CFLAGS = -g
+   endif
+   ifeq ($(uname_R),5)
+     CFLAGS = -g -O2 -Wall
+ #    CFLAGS = -g -O2
+   endif
+ endif
+ ifeq ($(uname_S),UnixWare)
+     CFLAGS = -g -O2 -Wall
+ #    CFLAGS = -g -O2
+ endif
  LDFLAGS =
  ALL_CFLAGS = $(CFLAGS)
  ALL_LDFLAGS = $(LDFLAGS)
***************
*** 206,212 ****
  
  export prefix bindir gitexecdir sharedir template_dir htmldir sysconfdir
  
! CC = gcc
  AR = ar
  RM = rm -f
  TAR = tar
--- 220,227 ----
  
  export prefix bindir gitexecdir sharedir template_dir htmldir sysconfdir
  
! #CC = gcc
! CC = "cc"
  AR = ar
  RM = rm -f
  TAR = tar
***************
*** 555,560 ****
  endif
  ifeq ($(uname_S),GNU/kFreeBSD)
  	NO_STRLCPY = YesPlease
  endif
  ifeq ($(uname_S),Darwin)
  	NEEDS_SSL_WITH_CRYPTO = YesPlease
--- 570,611 ----
  endif
  ifeq ($(uname_S),GNU/kFreeBSD)
  	NO_STRLCPY = YesPlease
+ endif
+ ifeq ($(uname_S),UnixWare)
+ 	NEEDS_SOCKET = YesPlease
+ #	NEEDS_NSL = YesPlease
+ 	NEEDS_SSL_WITH_CRYPTO = YesPlease
+ 	NEEDS_LIBICONV = YesPlease
+ 	SHELL_PATH = /usr/local/bin/bash
+ 	NO_IPV6 = YesPlease
+ 	NO_HSTRERROR = YesPlease
+ #	BASIC_CFLAGS +=  -E -H
+ 	BASIC_CFLAGS +=  -Kalloca -Kthread
+ 	BASIC_CFLAGS += -I/usr/local/include
+ 	BASIC_LDFLAGS += -L/usr/local/lib
+ 	INSTALL = ginstall
+ 	TAR = gtar
+ 	NO_STRCASESTR = YesPlease
+ 	NO_MEMMEM = YesPlease
+ endif
+ ifeq ($(uname_S),SCO_SV)
+ 	NEEDS_SOCKET = YesPlease
+ #	NEEDS_NSL = YesPlease
+ 	NEEDS_SSL_WITH_CRYPTO = YesPlease
+ 	NEEDS_LIBICONV = YesPlease
+ 	SHELL_PATH = /usr/bin/bash
+ 	NO_IPV6 = YesPlease
+ #	NO_HSTRERROR = YesPlease
+ #	BASIC_CFLAGS +=  -E -H
+       ifeq ($(uname_R),5)
+ 	BASIC_CFLAGS +=  -Kalloca -Kthread
+       endif
+ #	BASIC_CFLAGS += -I/usr/local/include
+ #	BASIC_LDFLAGS += -L/usr/local/lib
+ 	NO_STRCASESTR = YesPlease
+ 	NO_MEMMEM = YesPlease
+ 	INSTALL = ginstall
+ 	TAR = gtar
  endif
  ifeq ($(uname_S),Darwin)
  	NEEDS_SSL_WITH_CRYPTO = YesPlease
*** progress.c.orig Sun May 25 23:59:01 2008
--- progress.c Tue May 27 16:54:15 2008
***************
*** 241,247 ****
  	*p_progress = NULL;
  	if (progress->last_value != -1) {
  		/* Force the last update */
! 		char buf[strlen(msg) + 5];
  		struct throughput *tp = progress->throughput;
  		if (tp) {
  			unsigned int rate = !tp->avg_misecs ? 0 :
--- 241,248 ----
  	*p_progress = NULL;
  	if (progress->last_value != -1) {
  		/* Force the last update */
! 		/* char buf[strlen(msg) + 5]; */
! 		char *buf = malloc (strlen(msg) + 5 );
  		struct throughput *tp = progress->throughput;
  		if (tp) {
  			unsigned int rate = !tp->avg_misecs ? 0 :
Johannes Schindelin· Jun 5, 2008, 18:37 UTC · re: Boyd Lynn Gerber · lore

Re: Patches for some OS's.

Hi,
On Thu, 5 Jun 2008, Boyd Lynn Gerber wrote:
> I have attached the patches necessary to use GIT on some Non Linux OS's.

One might think that you could now use Git to generate the patches, and follow the conventions to submit them...

For example, reviewing attached patches makes it unduly hard on the reviewers.

For example, you do not have any explanation AKA commit message.
For example, you use context diffs.

See Documentation/SubmittingPatches for more hints how to get your patches integrated.

Hth, Dscho

Boyd Lynn Gerber· Jun 5, 2008, 18:49 UTC · re: Johannes Schindelin · lore

Re: Patches for some OS's.

On Thu, 5 Jun 2008, Johannes Schindelin wrote:
Show 5 quoted lines
> On Thu, 5 Jun 2008, Boyd Lynn Gerber wrote:
> > I have attached the patches necessary to use GIT on some Non Linux OS's.
>
> One might think that you could now use Git to generate the patches, and
> follow the conventions to submit them...

I should have. I am just now cloning the git tree. Once I get a my clone I will create a working copy and make the patches to it.

Show 9 quoted lines
> For example, reviewing attached patches makes it unduly hard on the
> reviewers.
>
> For example, you do not have any explanation AKA commit message.
>
> For example, you use context diffs.
>
> See Documentation/SubmittingPatches for more hints how to get your
> patches integrated.

I just found on the website the proper way to submit patches. I will follow it. I just have been submitting patches to to many differt version control systems. I have to submit patches to cvs, svn, hg and git. I have a hard time remembering which source tree is what. I have just now created my

/master/src/cvs /master/src/git /master/src/hg /master/src/svn /working/src/cvs /working/src/git /working/src/hg /working/src/svn

I am moving things to these directories. This will allow me to know which tools to use for each type of version control. I also still have SCCS and RCS repos as well. I really wish we could get the industry to standardize on git. But that will be a while.

Sorry, I did not follow the proper method, for submittal. I did not even know there was one when I submitted the patches. I will do them that way once I finish my migration above.

-- Boyd Gerber <gerberb@zenez.com> ZENEZ 1042 East Fort Union #135, Midvale Utah 84047

Boyd Lynn Gerber· Jun 5, 2008, 19:07 UTC · re: Boyd Lynn Gerber · lore

Re: Patches for some OS's.

On Thu, 5 Jun 2008, Boyd Lynn Gerber wrote:
Show 9 quoted lines
> On Thu, 5 Jun 2008, Johannes Schindelin wrote:
> > On Thu, 5 Jun 2008, Boyd Lynn Gerber wrote:
> > > I have attached the patches necessary to use GIT on some Non Linux OS's.
> >
> > One might think that you could now use Git to generate the patches, and
> > follow the conventions to submit them...
>
> I should have.  I am just now cloning the git tree.  Once I get a my clone
> I will create a working copy and make the patches to it.

But I also have to get things working on 20 different Linux/UNIX/Unix-Like variants. So I have 20 different OS specific directories. You would think you could be a little more tolerant of a person new to the list. I submitted my patches to what I thought was a patch list, not a general email list. So, I am sorry for my ignorance of the list/patching ediquit.

I will follow it from now on, but I may drop membership to the list. It takes a lot of time and git is just one tool of many, I have to use. I still have to use bitkeeper for the sources that use them. So please allow me time to adjust to your methods.

-- Boyd Gerber <gerberb@zenez.com> ZENEZ 1042 East Fort Union #135, Midvale Utah 84047

Johannes Schindelin· Jun 5, 2008, 19:35 UTC · re: Boyd Lynn Gerber · lore

Re: Patches for some OS's.

Hi,
On Thu, 5 Jun 2008, Boyd Lynn Gerber wrote:
Show 8 quoted lines
> On Thu, 5 Jun 2008, Boyd Lynn Gerber wrote:
>
> But I also have to get things working on 20 different 
> Linux/UNIX/Unix-Like variants.  So I have 20 different OS specific 
> directories.  You would think you could be a little more tolerant of a 
> person new to the list.  I submitted my patches to what I thought was a 
> patch list, not a general email list.  So, I am sorry for my ignorance 
> of the list/patching ediquit.

Hey, I did not mean to upset you! I would not have responded if I did not find your work valuable; However, I am too short on time to be overly polite. Sorry!

> I will follow it from now on, but I may drop membership to the list.  
> It takes a lot of time and git is just one tool of many, I have to use.  
> I still have to use bitkeeper for the sources that use them.  So please 
> allow me time to adjust to your methods.

Heh, Git is a high volume list, so nobody can blame you for dropping out because you are busy.

Ciao, Dscho

← back to recent threads