{"thread":{"id":"13815","subject":"Patches for some OS's.","startedAt":"2008-06-05T17:16:46Z","lastAt":"2008-06-05T19:35:57Z","messageCount":5,"participants":["Boyd Lynn Gerber","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"78788","messageId":"Pine.LNX.4.64.0806051114260.18454@xenau.zenez.com","threadId":"13815","inReplyTo":null,"subject":"Patches for some OS's.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-05T17:16:46Z","receivedAt":"2008-06-05T17:16:46Z","isPatch":false,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"Hello,\n\nI have attached the patches necessary to use GIT on some Non Linux OS's.\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n\n*** git-compat-util.h.orig Sun May 25 23:59:01 2008\n--- git-compat-util.h Mon May 26 13:02:43 2008\n***************\n*** 39,45 ****\n /* Approximation of the length of the decimal representation of this type. */\n #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n \n! #if !defined(__APPLE__) && !defined(__FreeBSD__)\n #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n #endif\n--- 39,45 ----\n /* Approximation of the length of the decimal representation of this type. */\n #define decimal_length(x)\t((int)(sizeof(x) * 2.56 + 0.5) + 1)\n \n! #if !defined(__APPLE__) && !defined(__FreeBSD__ ) && !defined(__USLC__) && !defined(_M_UNIX)\n #define _XOPEN_SOURCE 600 /* glibc2 and AIX 5.3L need 500, OpenBSD needs 600 for S_ISLNK() */\n #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */\n #endif\n***************\n*** 89,94 ****\n #include \n #define _ALL_SOURCE 1\n #endif\n \n #ifndef NO_ICONV\n #include \n--- 89,98 ----\n #include \n #define _ALL_SOURCE 1\n #endif\n+ #if defined(__USLC__)\n+ #undef _XOPEN_SOURCE\n+ #include \n+ #endif\n \n #ifndef NO_ICONV\n #include \n***************\n*** 206,211 ****\n #endif\n \n #ifdef FREAD_READS_DIRECTORIES\n #define fopen(a,b) git_fopen(a,b)\n extern FILE *git_fopen(const char*, const char*);\n #endif\n--- 210,216 ----\n #endif\n \n #ifdef FREAD_READS_DIRECTORIES\n+ #if !defined (__USLC__)\n #define fopen(a,b) git_fopen(a,b)\n extern FILE *git_fopen(const char*, const char*);\n #endif\n***************\n*** 208,213 ****\n #ifdef FREAD_READS_DIRECTORIES\n #define fopen(a,b) git_fopen(a,b)\n extern FILE *git_fopen(const char*, const char*);\n #endif\n \n #ifdef SNPRINTF_RETURNS_BOGUS\n--- 213,219 ----\n #if !defined (__USLC__)\n #define fopen(a,b) git_fopen(a,b)\n extern FILE *git_fopen(const char*, const char*);\n+ #endif\n #endif\n \n #ifdef SNPRINTF_RETURNS_BOGUS\n\n\n*** Makefile.orig Sun May 25 23:59:01 2008\n--- Makefile Mon May 26 11:33:07 2008\n***************\n*** 165,170 ****\n # CFLAGS and LDFLAGS are for the users to override from the command line.\n \n CFLAGS = -g -O2 -Wall\n LDFLAGS =\n ALL_CFLAGS = $(CFLAGS)\n ALL_LDFLAGS = $(LDFLAGS)\n--- 165,184 ----\n # CFLAGS and LDFLAGS are for the users to override from the command line.\n \n CFLAGS = -g -O2 -Wall\n+ ifeq ($(uname_S),SCO_SV)\n+ ifeq ($(uname_R),3.2)\n+ # CFLAGS = -g -O2\n+ CFLAGS = -g\n+ endif\n+ ifeq ($(uname_R),5)\n+ CFLAGS = -g -O2 -Wall\n+ # CFLAGS = -g -O2\n+ endif\n+ endif\n+ ifeq ($(uname_S),UnixWare)\n+ CFLAGS = -g -O2 -Wall\n+ # CFLAGS = -g -O2\n+ endif\n LDFLAGS =\n ALL_CFLAGS = $(CFLAGS)\n ALL_LDFLAGS = $(LDFLAGS)\n***************\n*** 206,212 ****\n \n export prefix bindir gitexecdir sharedir template_dir htmldir sysconfdir\n \n! CC = gcc\n AR = ar\n RM = rm -f\n TAR = tar\n--- 220,227 ----\n \n export prefix bindir gitexecdir sharedir template_dir htmldir sysconfdir\n \n! #CC = gcc\n! CC = \"cc\"\n AR = ar\n RM = rm -f\n TAR = tar\n***************\n*** 555,560 ****\n endif\n ifeq ($(uname_S),GNU/kFreeBSD)\n \tNO_STRLCPY = YesPlease\n endif\n ifeq ($(uname_S),Darwin)\n \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n--- 570,611 ----\n endif\n ifeq ($(uname_S),GNU/kFreeBSD)\n \tNO_STRLCPY = YesPlease\n+ endif\n+ ifeq ($(uname_S),UnixWare)\n+ \tNEEDS_SOCKET = YesPlease\n+ #\tNEEDS_NSL = YesPlease\n+ \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+ \tNEEDS_LIBICONV = YesPlease\n+ \tSHELL_PATH = /usr/local/bin/bash\n+ \tNO_IPV6 = YesPlease\n+ \tNO_HSTRERROR = YesPlease\n+ #\tBASIC_CFLAGS += -E -H\n+ \tBASIC_CFLAGS += -Kalloca -Kthread\n+ \tBASIC_CFLAGS += -I/usr/local/include\n+ \tBASIC_LDFLAGS += -L/usr/local/lib\n+ \tINSTALL = ginstall\n+ \tTAR = gtar\n+ \tNO_STRCASESTR = YesPlease\n+ \tNO_MEMMEM = YesPlease\n+ endif\n+ ifeq ($(uname_S),SCO_SV)\n+ \tNEEDS_SOCKET = YesPlease\n+ #\tNEEDS_NSL = YesPlease\n+ \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n+ \tNEEDS_LIBICONV = YesPlease\n+ \tSHELL_PATH = /usr/bin/bash\n+ \tNO_IPV6 = YesPlease\n+ #\tNO_HSTRERROR = YesPlease\n+ #\tBASIC_CFLAGS += -E -H\n+ ifeq ($(uname_R),5)\n+ \tBASIC_CFLAGS += -Kalloca -Kthread\n+ endif\n+ #\tBASIC_CFLAGS += -I/usr/local/include\n+ #\tBASIC_LDFLAGS += -L/usr/local/lib\n+ \tNO_STRCASESTR = YesPlease\n+ \tNO_MEMMEM = YesPlease\n+ \tINSTALL = ginstall\n+ \tTAR = gtar\n endif\n ifeq ($(uname_S),Darwin)\n \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n\n\n*** progress.c.orig Sun May 25 23:59:01 2008\n--- progress.c Tue May 27 16:54:15 2008\n***************\n*** 241,247 ****\n \t*p_progress = NULL;\n \tif (progress->last_value != -1) {\n \t\t/* Force the last update */\n! \t\tchar buf[strlen(msg) + 5];\n \t\tstruct throughput *tp = progress->throughput;\n \t\tif (tp) {\n \t\t\tunsigned int rate = !tp->avg_misecs ? 0 :\n--- 241,248 ----\n \t*p_progress = NULL;\n \tif (progress->last_value != -1) {\n \t\t/* Force the last update */\n! \t\t/* char buf[strlen(msg) + 5]; */\n! \t\tchar *buf = malloc (strlen(msg) + 5 );\n \t\tstruct throughput *tp = progress->throughput;\n \t\tif (tp) {\n \t\t\tunsigned int rate = !tp->avg_misecs ? 0 :\n"},{"id":"78793","messageId":"alpine.DEB.1.00.0806051935540.21190@racer","threadId":"13815","inReplyTo":"Pine.LNX.4.64.0806051114260.18454@xenau.zenez.com","subject":"Re: Patches for some OS's.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-06-05T18:37:17Z","receivedAt":"2008-06-05T18:37:17Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 5 Jun 2008, Boyd Lynn Gerber wrote:\n\n> I have attached the patches necessary to use GIT on some Non Linux OS's.\n\nOne might think that you could now use Git to generate the patches, and \nfollow the conventions to submit them...\n\nFor example, reviewing attached patches makes it unduly hard on the \nreviewers.\n\nFor example, you do not have any explanation AKA commit message.\n\nFor example, you use context diffs.\n\nSee Documentation/SubmittingPatches for more hints how to get your patches \nintegrated.\n\nHth,\nDscho\n"},{"id":"78798","messageId":"Pine.LNX.4.64.0806051240550.18454@xenau.zenez.com","threadId":"13815","inReplyTo":"alpine.DEB.1.00.0806051935540.21190@racer","subject":"Re: Patches for some OS's.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-05T18:49:07Z","receivedAt":"2008-06-05T18:49:07Z","isPatch":false,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Thu, 5 Jun 2008, Johannes Schindelin wrote:\n> On Thu, 5 Jun 2008, Boyd Lynn Gerber wrote:\n> > I have attached the patches necessary to use GIT on some Non Linux OS's.\n>\n> One might think that you could now use Git to generate the patches, and\n> follow the conventions to submit them...\n\nI should have. I am just now cloning the git tree. Once I get a my clone\nI will create a working copy and make the patches to it.\n\n> For example, reviewing attached patches makes it unduly hard on the\n> reviewers.\n>\n> For example, you do not have any explanation AKA commit message.\n>\n> For example, you use context diffs.\n>\n> See Documentation/SubmittingPatches for more hints how to get your\n> patches integrated.\n\nI just found on the website the proper way to submit patches. I will\nfollow it. I just have been submitting patches to to many differt version\ncontrol systems. I have to submit patches to cvs, svn, hg and git. I\nhave a hard time remembering which source tree is what. I have just now\ncreated my\n\n/master/src/cvs\n/master/src/git\n/master/src/hg\n/master/src/svn\n/working/src/cvs\n/working/src/git\n/working/src/hg\n/working/src/svn\n\nI am moving things to these directories. This will allow me to know which\ntools to use for each type of version control. I also still have SCCS and\nRCS repos as well. I really wish we could get the industry to standardize\non git. But that will be a while.\n\nSorry, I did not follow the proper method, for submittal. I did not even\nknow there was one when I submitted the patches. I will do them that way\nonce I finish my migration above.\n\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"78800","messageId":"Pine.LNX.4.64.0806051301500.18454@xenau.zenez.com","threadId":"13815","inReplyTo":"Pine.LNX.4.64.0806051240550.18454@xenau.zenez.com","subject":"Re: Patches for some OS's.","fromName":"Boyd Lynn Gerber","fromEmail":"gerberb@zenez.com","sentAt":"2008-06-05T19:07:30Z","receivedAt":"2008-06-05T19:07:30Z","isPatch":false,"sender":{"key":"gerberb@zenez.com","avatar":null},"body":"On Thu, 5 Jun 2008, Boyd Lynn Gerber wrote:\n> On Thu, 5 Jun 2008, Johannes Schindelin wrote:\n> > On Thu, 5 Jun 2008, Boyd Lynn Gerber wrote:\n> > > I have attached the patches necessary to use GIT on some Non Linux OS's.\n> >\n> > One might think that you could now use Git to generate the patches, and\n> > follow the conventions to submit them...\n>\n> I should have. I am just now cloning the git tree. Once I get a my clone\n> I will create a working copy and make the patches to it.\n\nBut I also have to get things working on 20 different Linux/UNIX/Unix-Like\nvariants. So I have 20 different OS specific directories. You would\nthink you could be a little more tolerant of a person new to the list. I\nsubmitted my patches to what I thought was a patch list, not a general\nemail list. So, I am sorry for my ignorance of the list/patching ediquit.\n\nI will follow it from now on, but I may drop membership to the list. It\ntakes a lot of time and git is just one tool of many, I have to use. I\nstill have to use bitkeeper for the sources that use them. So please\nallow me time to adjust to your methods.\n\n\n--\nBoyd Gerber \nZENEZ\t1042 East Fort Union #135, Midvale Utah 84047\n"},{"id":"78803","messageId":"alpine.DEB.1.00.0806052034340.21190@racer","threadId":"13815","inReplyTo":"Pine.LNX.4.64.0806051301500.18454@xenau.zenez.com","subject":"Re: Patches for some OS's.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-06-05T19:35:57Z","receivedAt":"2008-06-05T19:35:57Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 5 Jun 2008, Boyd Lynn Gerber wrote:\n\n> On Thu, 5 Jun 2008, Boyd Lynn Gerber wrote:\n>\n> But I also have to get things working on 20 different \n> Linux/UNIX/Unix-Like variants. So I have 20 different OS specific \n> directories. You would think you could be a little more tolerant of a \n> person new to the list. I submitted my patches to what I thought was a \n> patch list, not a general email list. So, I am sorry for my ignorance \n> of the list/patching ediquit.\n\nHey, I did not mean to upset you! I would not have responded if I did not \nfind your work valuable; However, I am too short on time to be overly \npolite. Sorry!\n\n> I will follow it from now on, but I may drop membership to the list. \n> It takes a lot of time and git is just one tool of many, I have to use. \n> I still have to use bitkeeper for the sources that use them. So please \n> allow me time to adjust to your methods.\n\nHeh, Git is a high volume list, so nobody can blame you for dropping out \nbecause you are busy.\n\nCiao,\nDscho\n"}]}