threads / patch / 13631

patch[ is explicitly disallowed by bad_ref_char

Subject: [PATCH] [ is explicitly disallowed by bad_ref_char

## tl;dr

3 messages between May 23, 2008 and May 23, 2008. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Paul Oliver· May 23, 2008, 08:42 UTC · lore

---
 git-cvsimport.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to git-cvsimport.perl +1 −0

diff --git a/git-cvsimport.perl b/git-cvsimport.perl
index bdac5d5..5a02550 100755
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -780,6 +780,7 @@ sub commit {
 		$xtag =~ s/\s+\*\*.*$//; # Remove stuff like ** INVALID ** and ** FUNKY **
 		$xtag =~ tr/_/\./ if ( $opt_u );
 		$xtag =~ s/[\/]/$opt_s/g;
+		$xtag =~ s/\[//g;

 		system('git-tag', '-f', $xtag, $cid) == 0
 			or die "Cannot create tag $xtag: $!\n";

-- 
1.5.3.6

Miklos Vajna· May 23, 2008, 10:39 UTC · re: Paul Oliver · lore

Re: [PATCH] [ is explicitly disallowed by bad_ref_char

On Fri, May 23, 2008 at 09:42:04AM +0100, Paul Oliver <puzza007@gmail.com> wrote:

> ---
>  git-cvsimport.perl |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Could you please improve the commit message a bit? Just running git-log won't let to you know this patch touches git-cvsimport only, which is an important information here.

Junio C Hamano· May 23, 2008, 17:58 UTC · re: Miklos Vajna · lore

Re: [PATCH] [ is explicitly disallowed by bad_ref_char

Miklos Vajna <vmiklos@frugalware.org> writes:

Show 8 quoted lines

> On Fri, May 23, 2008 at 09:42:04AM +0100, Paul Oliver <puzza007@gmail.com> wrote:
>> ---
>>  git-cvsimport.perl |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> Could you please improve the commit message a bit? Just running git-log
> won't let to you know this patch touches git-cvsimport only, which is an
> important information here.

Also please sign-off your patch.