# [PATCH] [ is explicitly disallowed by bad_ref_char 3 messages from 2008-05-23 to 2008-05-23. Participants: Paul Oliver, Miklos Vajna, Junio C Hamano. Thread: https://gitlist.dev/t/13631 ## Paul Oliver, 2008-05-23 08:42 Subject: [PATCH] [ is explicitly disallowed by bad_ref_char Message-ID: URL: https://gitlist.dev/e/a4cc77ec0805230142n7dda9f7ahe4bde3b80f369220%40mail.gmail.com ``` --- git-cvsimport.perl | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/git-cvsimport.perl b/git-cvsimport.perl index bdac5d5..5a02550 100755 --- a/git-cvsimport.perl +++ b/git-cvsimport.perl @@ -780,6 +780,7 @@ sub commit { $xtag =~ s/\s+\*\*.*$//; # Remove stuff like ** INVALID ** and ** FUNKY ** $xtag =~ tr/_/\./ if ( $opt_u ); $xtag =~ s/[\/]/$opt_s/g; + $xtag =~ s/\[//g; system('git-tag', '-f', $xtag, $cid) == 0 or die "Cannot create tag $xtag: $!\n"; -- 1.5.3.6 ``` ## Miklos Vajna, 2008-05-23 10:39 Subject: Re: [PATCH] [ is explicitly disallowed by bad_ref_char Message-ID: <20080523103906.GO27724@genesis.frugalware.org> URL: https://gitlist.dev/e/20080523103906.GO27724%40genesis.frugalware.org In-Reply-To: ``` On Fri, May 23, 2008 at 09:42:04AM +0100, Paul Oliver wrote: > --- > git-cvsimport.perl | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Could you please improve the commit message a bit? Just running git-log won't let to you know this patch touches git-cvsimport only, which is an important information here. ``` ## Junio C Hamano, 2008-05-23 17:58 Subject: Re: [PATCH] [ is explicitly disallowed by bad_ref_char Message-ID: <7vlk20sy1g.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vlk20sy1g.fsf%40gitster.siamese.dyndns.org In-Reply-To: <20080523103906.GO27724@genesis.frugalware.org> ``` Miklos Vajna writes: > On Fri, May 23, 2008 at 09:42:04AM +0100, Paul Oliver wrote: >> --- >> git-cvsimport.perl | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) > > Could you please improve the commit message a bit? Just running git-log > won't let to you know this patch touches git-cvsimport only, which is an > important information here. Also please sign-off your patch. ```