threads / bug / 13550

[BUG] make test fails on osx (t7502-commit.sh)

Subject: [BUG] make test fails on osx (t7502-commit.sh)

## tl;dr

3 messages between May 16, 2008 and May 18, 2008.

replies: 2people: 2as markdown or json

Rhodes, Kate· May 16, 2008, 23:59 UTC · lore

just checked out the main branch 1fbb58b4153e90eda08c2b022ee32d90729582e6 The offending message from make test follows.

-Kate P.S. My apologies if this is a dupe. I didn't see it when i searched the archives.

*** t7502-commit.sh ***
*   ok 1: the basics
*   ok 2: partial
*   ok 3: partial modification in a subdirecotry
*   ok 4: partial removal
*   ok 5: sign off
*   ok 6: multiple -m
*   ok 7: verbose
*   ok 8: cleanup commit messages (verbatim,-t)
*   ok 9: cleanup commit messages (verbatim,-F)
*   ok 10: cleanup commit messages (verbatim,-m)
*   ok 11: cleanup commit messages (whitespace,-F)
*   ok 12: cleanup commit messages (strip,-F)
*   ok 13: cleanup commit messages (strip,-F,-e)
*   ok 14: author different from committer
sed: 1: "expect": invalid command code e
* FAIL 15: committer is automatic
	
	
		echo >>negative &&
		git commit -e -m "sample"
		head -n 8 .git/COMMIT_EDITMSG |	\
		sed "s/^# Committer: .*/# Committer:/" >actual &&
		test_cmp expect actual
	
*   ok 16: do not fire editor in the presence of conflicts
* failed 1 among 16 test(s)
make[1]: *** [t7502-commit.sh] Error 1
make: *** [test] Error 2

Kevin Ballard· May 17, 2008, 02:58 UTC · re: Rhodes, Kate · lore

Re: [BUG] make test fails on osx (t7502-commit.sh)

Hi.

On May 16, 2008, at 7:59 PM, Rhodes, Kate wrote:

Show 38 quoted lines

> just checked out the main branch  
> 1fbb58b4153e90eda08c2b022ee32d90729582e6
> The offending message from make test follows.
>
> -Kate
> P.S. My apologies if this is a dupe. I didn't see it when i searched  
> the archives.
>
>
> *** t7502-commit.sh ***
> *   ok 1: the basics
> *   ok 2: partial
> *   ok 3: partial modification in a subdirecotry
> *   ok 4: partial removal
> *   ok 5: sign off
> *   ok 6: multiple -m
> *   ok 7: verbose
> *   ok 8: cleanup commit messages (verbatim,-t)
> *   ok 9: cleanup commit messages (verbatim,-F)
> *   ok 10: cleanup commit messages (verbatim,-m)
> *   ok 11: cleanup commit messages (whitespace,-F)
> *   ok 12: cleanup commit messages (strip,-F)
> *   ok 13: cleanup commit messages (strip,-F,-e)
> *   ok 14: author different from committer
> sed: 1: "expect": invalid command code e
> * FAIL 15: committer is automatic
> 	
> 	
> 		echo >>negative &&
> 		git commit -e -m "sample"
> 		head -n 8 .git/COMMIT_EDITMSG |	\
> 		sed "s/^# Committer: .*/# Committer:/" >actual &&
> 		test_cmp expect actual
> 	
> *   ok 16: do not fire editor in the presence of conflicts
> * failed 1 among 16 test(s)
> make[1]: *** [t7502-commit.sh] Error 1
> make: *** [test] Error 2\

See http://marc.info/?l=git&m=121089732118252&w=2. A patch was submitted to fix this problem, but apparently hasn't been accepted yet.

-Kevin Ballard

-- 
Kevin Ballard
http://kevin.sb.org
kevin@sb.org
http://www.tildesoft.com

Rhodes, Kate· May 18, 2008, 22:13 UTC · re: Kevin Ballard · lore

Re: [BUG] make test fails on osx (t7502-commit.sh)

On May 16, 2008, at 10:58 PM, Kevin Ballard wrote:

Show 5 quoted lines

> On May 16, 2008, at 7:59 PM, Rhodes, Kate wrote:
>
>> just checked out the main branch  
>> 1fbb58b4153e90eda08c2b022ee32d90729582e6
>> The offending message from make test follows.

[snip]

>
> See http://marc.info/?l=git&m=121089732118252&w=2. A patch was  
> submitted to fix this problem, but apparently hasn't been accepted  
> yet.

[snip]

Thanks. I can confirm that that patch fixed it for me.

-Kate