# [BUG] make test fails on osx (t7502-commit.sh)

3 messages from 2008-05-16 to 2008-05-18. Participants: Rhodes, Kate, Kevin Ballard.
Thread: https://gitlist.dev/t/13550

## Rhodes, Kate, 2008-05-16 23:59

Subject: [BUG] make test fails on osx (t7502-commit.sh)
Message-ID: <75B80F22-AC86-4D3F-A7E6-7DE70AEE5114@gmail.com>
URL: https://gitlist.dev/e/75B80F22-AC86-4D3F-A7E6-7DE70AEE5114%40gmail.com

```
just checked out the main branch  
1fbb58b4153e90eda08c2b022ee32d90729582e6
The offending message from make test follows.

-Kate
P.S. My apologies if this is a dupe. I didn't see it when i searched  
the archives.


*** t7502-commit.sh ***
*   ok 1: the basics
*   ok 2: partial
*   ok 3: partial modification in a subdirecotry
*   ok 4: partial removal
*   ok 5: sign off
*   ok 6: multiple -m
*   ok 7: verbose
*   ok 8: cleanup commit messages (verbatim,-t)
*   ok 9: cleanup commit messages (verbatim,-F)
*   ok 10: cleanup commit messages (verbatim,-m)
*   ok 11: cleanup commit messages (whitespace,-F)
*   ok 12: cleanup commit messages (strip,-F)
*   ok 13: cleanup commit messages (strip,-F,-e)
*   ok 14: author different from committer
sed: 1: "expect": invalid command code e
* FAIL 15: committer is automatic
	
	
		echo >>negative &&
		git commit -e -m "sample"
		head -n 8 .git/COMMIT_EDITMSG |	\
		sed "s/^# Committer: .*/# Committer:/" >actual &&
		test_cmp expect actual
	
*   ok 16: do not fire editor in the presence of conflicts
* failed 1 among 16 test(s)
make[1]: *** [t7502-commit.sh] Error 1
make: *** [test] Error 2

```

## Kevin Ballard, 2008-05-17 02:58

Subject: Re: [BUG] make test fails on osx (t7502-commit.sh)
Message-ID: <46A56F20-DFB7-451E-9E81-71FA51FE1E27@sb.org>
URL: https://gitlist.dev/e/46A56F20-DFB7-451E-9E81-71FA51FE1E27%40sb.org
In-Reply-To: <75B80F22-AC86-4D3F-A7E6-7DE70AEE5114@gmail.com>

```
Hi.

On May 16, 2008, at 7:59 PM, Rhodes, Kate wrote:

> just checked out the main branch  
> 1fbb58b4153e90eda08c2b022ee32d90729582e6
> The offending message from make test follows.
>
> -Kate
> P.S. My apologies if this is a dupe. I didn't see it when i searched  
> the archives.
>
>
> *** t7502-commit.sh ***
> *   ok 1: the basics
> *   ok 2: partial
> *   ok 3: partial modification in a subdirecotry
> *   ok 4: partial removal
> *   ok 5: sign off
> *   ok 6: multiple -m
> *   ok 7: verbose
> *   ok 8: cleanup commit messages (verbatim,-t)
> *   ok 9: cleanup commit messages (verbatim,-F)
> *   ok 10: cleanup commit messages (verbatim,-m)
> *   ok 11: cleanup commit messages (whitespace,-F)
> *   ok 12: cleanup commit messages (strip,-F)
> *   ok 13: cleanup commit messages (strip,-F,-e)
> *   ok 14: author different from committer
> sed: 1: "expect": invalid command code e
> * FAIL 15: committer is automatic
> 	
> 	
> 		echo >>negative &&
> 		git commit -e -m "sample"
> 		head -n 8 .git/COMMIT_EDITMSG |	\
> 		sed "s/^# Committer: .*/# Committer:/" >actual &&
> 		test_cmp expect actual
> 	
> *   ok 16: do not fire editor in the presence of conflicts
> * failed 1 among 16 test(s)
> make[1]: *** [t7502-commit.sh] Error 1
> make: *** [test] Error 2\

See http://marc.info/?l=git&m=121089732118252&w=2. A patch was  
submitted to fix this problem, but apparently hasn't been accepted yet.

-Kevin Ballard

-- 
Kevin Ballard
http://kevin.sb.org
kevin@sb.org
http://www.tildesoft.com

```

## Rhodes, Kate, 2008-05-18 22:13

Subject: Re: [BUG] make test fails on osx (t7502-commit.sh)
Message-ID: <1A30A982-33B4-45BD-8291-FE1F61AFD6F9@gmail.com>
URL: https://gitlist.dev/e/1A30A982-33B4-45BD-8291-FE1F61AFD6F9%40gmail.com
In-Reply-To: <46A56F20-DFB7-451E-9E81-71FA51FE1E27@sb.org>

```
On May 16, 2008, at 10:58 PM, Kevin Ballard wrote:
> On May 16, 2008, at 7:59 PM, Rhodes, Kate wrote:
>
>> just checked out the main branch  
>> 1fbb58b4153e90eda08c2b022ee32d90729582e6
>> The offending message from make test follows.

[snip]

>
> See http://marc.info/?l=git&m=121089732118252&w=2. A patch was  
> submitted to fix this problem, but apparently hasn't been accepted  
> yet.

[snip]

Thanks. I can confirm that that patch fixed it for me.

-Kate

```