threads / discuss / 13263

RFC822 From: fields

Subject: RFC822 From: fields

## tl;dr

4 messages between Apr 25, 2008 and Apr 26, 2008.

replies: 3people: 3as markdown or json

Stephen R. van den Berg· Apr 25, 2008, 23:51 UTC · lore

I noticed that the From: field generated by git-format-patch does not conform to RFC822 format when the realname contains a dot (like mine). Do we want to fix that in git-format-patch (only), or do we even want to fix that in the stored commit author and committer fields?

-- 
Sincerely,                                                          srb@cuci.nl
           Stephen R. van den Berg.

Junio C Hamano· Apr 26, 2008, 00:01 UTC · re: Stephen R. van den Berg · lore

Re: RFC822 From: fields

"Stephen R. van den Berg" <srb@cuci.nl> writes:

> I noticed that the From: field generated by git-format-patch does not
> conform to RFC822 format when the realname contains a dot (like mine).
> Do we want to fix that in git-format-patch (only), or do we even want to
> fix that in the stored commit author and committer fields?

I'd suspect that the answer should be "Neither", and rather inside send-email.

Florian Weimer· Apr 26, 2008, 08:49 UTC · re: Stephen R. van den Berg · lore

Re: RFC822 From: fields

* Stephen R. van den Berg:

> I noticed that the From: field generated by git-format-patch does not
> conform to RFC822 format when the realname contains a dot (like mine).
> Do we want to fix that in git-format-patch (only), or do we even want to
> fix that in the stored commit author and committer fields?

This was fixed in RFC 2822, and the fix has already been deployed widely (even before the advent of RFC 2822). I don't think there's any need to change GIT.

Stephen R. van den Berg· Apr 26, 2008, 11:45 UTC · re: Florian Weimer · lore

Re: RFC822 From: fields

Florian Weimer wrote:

>* Stephen R. van den Berg:
>> I noticed that the From: field generated by git-format-patch does not
>> conform to RFC822 format when the realname contains a dot (like mine).

>This was fixed in RFC 2822, and the fix has already been deployed widely
>(even before the advent of RFC 2822).  I don't think there's any need to
>change GIT.

True indeed. Ironically, the vger.kernel.org mailserver adheres to RFC822 and ignores RFC2822 at the moment, which means that generating patches from git, for the git mailinglist doesn't work without intervention. I already contacted the vger-mailserver admin about this.

-- 
Sincerely,                                                          srb@cuci.nl
           Stephen R. van den Berg.