# RFC822 From: fields 4 messages from 2008-04-25 to 2008-04-26. Participants: Stephen R. van den Berg, Junio C Hamano, Florian Weimer. Thread: https://gitlist.dev/t/13263 ## Stephen R. van den Berg, 2008-04-25 23:51 Subject: RFC822 From: fields Message-ID: <20080425235142.GA6347@cuci.nl> URL: https://gitlist.dev/e/20080425235142.GA6347%40cuci.nl ``` I noticed that the From: field generated by git-format-patch does not conform to RFC822 format when the realname contains a dot (like mine). Do we want to fix that in git-format-patch (only), or do we even want to fix that in the stored commit author and committer fields? -- Sincerely, srb@cuci.nl Stephen R. van den Berg. ``` ## Junio C Hamano, 2008-04-26 00:01 Subject: Re: RFC822 From: fields Message-ID: <7vod7xo55m.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vod7xo55m.fsf%40gitster.siamese.dyndns.org In-Reply-To: <20080425235142.GA6347@cuci.nl> ``` "Stephen R. van den Berg" writes: > I noticed that the From: field generated by git-format-patch does not > conform to RFC822 format when the realname contains a dot (like mine). > Do we want to fix that in git-format-patch (only), or do we even want to > fix that in the stored commit author and committer fields? I'd suspect that the answer should be "Neither", and rather inside send-email. ``` ## Florian Weimer, 2008-04-26 08:49 Subject: Re: RFC822 From: fields Message-ID: <87r6ctatma.fsf@mid.deneb.enyo.de> URL: https://gitlist.dev/e/87r6ctatma.fsf%40mid.deneb.enyo.de In-Reply-To: <20080425235142.GA6347@cuci.nl> ``` * Stephen R. van den Berg: > I noticed that the From: field generated by git-format-patch does not > conform to RFC822 format when the realname contains a dot (like mine). > Do we want to fix that in git-format-patch (only), or do we even want to > fix that in the stored commit author and committer fields? This was fixed in RFC 2822, and the fix has already been deployed widely (even before the advent of RFC 2822). I don't think there's any need to change GIT. ``` ## Stephen R. van den Berg, 2008-04-26 11:45 Subject: Re: RFC822 From: fields Message-ID: <20080426114518.GA19558@cuci.nl> URL: https://gitlist.dev/e/20080426114518.GA19558%40cuci.nl In-Reply-To: <87r6ctatma.fsf@mid.deneb.enyo.de> ``` Florian Weimer wrote: >* Stephen R. van den Berg: >> I noticed that the From: field generated by git-format-patch does not >> conform to RFC822 format when the realname contains a dot (like mine). >This was fixed in RFC 2822, and the fix has already been deployed widely >(even before the advent of RFC 2822). I don't think there's any need to >change GIT. True indeed. Ironically, the vger.kernel.org mailserver adheres to RFC822 and ignores RFC2822 at the moment, which means that generating patches from git, for the git mailinglist doesn't work without intervention. I already contacted the vger-mailserver admin about this. -- Sincerely, srb@cuci.nl Stephen R. van den Berg. ```