threads / discuss / 13183

git-svn but with blank commits and author file

Subject: git-svn but with blank commits and author file

## tl;dr

One message between Apr 20, 2008 and Apr 20, 2008.

replies: 0people: 1as markdown or json

Thomas Guyot-Sionnest· Apr 20, 2008, 00:44 UTC · lore
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

When trying to import from svn using an author file, git-svn bails out if it encounters a blank author. The attached patch breaks this behavior and allow using the author file with blanks authors.

I came across this bug while importing from a cvs2svn repo where the
initial revision (1) has a blank author. This doesn't break the behavior
 of bailing out when an unknown author is encountered.
The patch was made this morning against Git's HEAD.
If you reply please make sure to cc me as I'm not subscribed to the list.
Thanks,
- --
Thomas Guyot
dermoth@aei.ca
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFICpHo6dZ+Kt5BchYRAltpAJ4mPuN+uhucMpvDbXVKLfb2IzBIXQCghnf6 NoPN55yRj0eIhDowvWTQ0r4= =48zw -----END PGP SIGNATURE-----

--- git-svn.perl.orig 2008-04-19 05:58:10.000000000 -0400 +++ git-svn.perl 2008-04-19 19:50:40.000000000 -0400

@@ -2375,8 +2375,7 @@
 	my ($author) = @_;
 	if (!defined $author || length $author == 0) {
 		$author = '(no author)';
-	}
-	if (defined $::_authors && ! defined $::users{$author}) {
+	} elsif (defined $::_authors && ! defined $::users{$author}) {
 		die "Author: $author not defined in $::_authors file\n";
 	}
 	$author;

← back to recent threads