{"thread":{"id":"13183","subject":"git-svn but with blank commits and author file","startedAt":"2008-04-20T00:44:24Z","lastAt":"2008-04-20T00:44:24Z","messageCount":1,"participants":["Thomas Guyot-Sionnest"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"74789","messageId":"480A91E8.1090907@aei.ca","threadId":"13183","inReplyTo":null,"subject":"git-svn but with blank commits and author file","fromName":"Thomas Guyot-Sionnest","fromEmail":"dermoth@aei.ca","sentAt":"2008-04-20T00:44:24Z","receivedAt":"2008-04-20T00:44:24Z","isPatch":false,"sender":{"key":"dermoth@aei.ca","avatar":null},"body":"-----BEGIN PGP SIGNED MESSAGE-----\nHash: SHA1\n\nWhen trying to import from svn using an author file, git-svn bails out\nif it encounters a blank author. The attached patch breaks this behavior\nand allow using the author file with blanks authors.\n\nI came across this bug while importing from a cvs2svn repo where the\ninitial revision (1) has a blank author. This doesn't break the behavior\n of bailing out when an unknown author is encountered.\n\nThe patch was made this morning against Git's HEAD.\n\nIf you reply please make sure to cc me as I'm not subscribed to the list.\n\nThanks,\n\n- --\nThomas Guyot\ndermoth@aei.ca\n-----BEGIN PGP SIGNATURE-----\nVersion: GnuPG v1.4.6 (GNU/Linux)\nComment: Using GnuPG with Mozilla - http://enigmail.mozdev.org\n\niD8DBQFICpHo6dZ+Kt5BchYRAltpAJ4mPuN+uhucMpvDbXVKLfb2IzBIXQCghnf6\nNoPN55yRj0eIhDowvWTQ0r4=\n=48zw\n-----END PGP SIGNATURE-----\n\n\n--- git-svn.perl.orig\t2008-04-19 05:58:10.000000000 -0400\n+++ git-svn.perl\t2008-04-19 19:50:40.000000000 -0400\n@@ -2375,8 +2375,7 @@\n \tmy ($author) = @_;\n \tif (!defined $author || length $author == 0) {\n \t\t$author = '(no author)';\n-\t}\n-\tif (defined $::_authors && ! defined $::users{$author}) {\n+\t} elsif (defined $::_authors && ! defined $::users{$author}) {\n \t\tdie \"Author: $author not defined in $::_authors file\\n\";\n \t}\n \t$author;\n"}]}