Re: [PATCH] git-svn: find-rev error message when missing arg
"Marc-Andre Lureau (elmarco)" <marcandre.lureau@gmail.com> wrote:
> Just let the user know that a revision argument is missing instead of
> a perl error. This error message mimic the "init" error message, but
> could be improved.
Thanks Marc-Andre. Three small things:
* Minor spelling error noted below.
* Please wrap your commit message lines at 72 characters or less.
* Sign-off?
Tentatively-Acked-by: Eric Wong <normalperson@yhbt.net>
Show 14 quoted lines
> ---
> git-svn.perl | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/git-svn.perl b/git-svn.perl
> index 1195569..2ee7ca5 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -522,7 +522,8 @@ sub cmd_dcommit {
> }
>
> sub cmd_find_rev {
> - my $revision_or_hash = shift;
> + my $revision_or_hash = shift or die "SVN or git revison required ",Show 5 quoted lines
> + "as a command-line argument\n";
> my $result;
> if ($revision_or_hash =~ /^r\d+$/) {
> my $head = shift;
> -- --
Eric Wong
Marc-Andre Lureau (elmarco)