{"thread":{"id":"12627","subject":"[PATCH] git-svn: find-rev error message when missing arg","startedAt":"2008-03-11T01:52:26Z","lastAt":"2008-03-11T20:46:06Z","messageCount":5,"participants":["Marc-Andre Lureau (elmarco)","Eric Wong","Marc-Andre Lureau","Marc-André Lureau"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"71637","messageId":"1205200346-5537-1-git-send-email-marcandre.lureau@gmail.com","threadId":"12627","inReplyTo":null,"subject":"[PATCH] git-svn: find-rev error message when missing arg","fromName":"Marc-Andre Lureau (elmarco)","fromEmail":"marcandre.lureau@gmail.com","sentAt":"2008-03-11T01:52:26Z","receivedAt":"2008-03-11T01:52:26Z","isPatch":true,"sender":{"key":"marcandre.lureau@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9381?v=4"},"body":"Just let the user know that a revision argument is missing instead of a perl error. This error message mimic the \"init\" error message, but could be improved.\n---\n git-svn.perl | 3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 1195569..2ee7ca5 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -522,7 +522,8 @@ sub cmd_dcommit {\n }\n \n sub cmd_find_rev {\n-\tmy $revision_or_hash = shift;\n+\tmy $revision_or_hash = shift or die \"SVN or git revison required \",\n+\t \"as a command-line argument\\n\";\n \tmy $result;\n \tif ($revision_or_hash =~ /^r\\d+$/) {\n \t\tmy $head = shift;\n-- \n1.5.4.4.482.ga8b1\n"},{"id":"71653","messageId":"20080311051910.GB9389@hand.yhbt.net","threadId":"12627","inReplyTo":"1205200346-5537-1-git-send-email-marcandre.lureau@gmail.com","subject":"Re: [PATCH] git-svn: find-rev error message when missing arg","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2008-03-11T05:19:10Z","receivedAt":"2008-03-11T05:19:10Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"\"Marc-Andre Lureau (elmarco)\" wrote:\n> Just let the user know that a revision argument is missing instead of\n> a perl error. This error message mimic the \"init\" error message, but\n> could be improved.\n\nThanks Marc-Andre. Three small things:\n\n* Minor spelling error noted below.\n* Please wrap your commit message lines at 72 characters or less.\n* Sign-off?\n\nTentatively-Acked-by: Eric Wong \n\n> ---\n> git-svn.perl | 3 ++-\n> 1 files changed, 2 insertions(+), 1 deletions(-)\n> \n> diff --git a/git-svn.perl b/git-svn.perl\n> index 1195569..2ee7ca5 100755\n> --- a/git-svn.perl\n> +++ b/git-svn.perl\n> @@ -522,7 +522,8 @@ sub cmd_dcommit {\n> }\n> \n> sub cmd_find_rev {\n> -\tmy $revision_or_hash = shift;\n> +\tmy $revision_or_hash = shift or die \"SVN or git revison required \",\n revision\n> +\t \"as a command-line argument\\n\";\n> \tmy $result;\n> \tif ($revision_or_hash =~ /^r\\d+$/) {\n> \t\tmy $head = shift;\n> -- \n\n-- \nEric Wong\n"},{"id":"71666","messageId":"1205222445-8077-1-git-send-email-marcandre.lureau@gmail.com","threadId":"12627","inReplyTo":"20080311051910.GB9389@hand.yhbt.net","subject":"[PATCH] git-svn: find-rev error message when missing arg","fromName":"Marc-Andre Lureau","fromEmail":"marcandre.lureau@gmail.com","sentAt":"2008-03-11T08:00:45Z","receivedAt":"2008-03-11T08:00:45Z","isPatch":true,"sender":{"key":"marcandre.lureau@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9381?v=4"},"body":"Just let the user know that a revision argument is missing instead of\na perl error. This error message mimic the \"init\" error message, but\ncould be improved.\n\nSigned-off-by: Marc-Andre Lureau \n---\n git-svn.perl | 3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 1195569..d8b38c9 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -522,7 +522,8 @@ sub cmd_dcommit {\n }\n \n sub cmd_find_rev {\n-\tmy $revision_or_hash = shift;\n+\tmy $revision_or_hash = shift or die \"SVN or git revision required \",\n+\t \"as a command-line argument\\n\";\n \tmy $result;\n \tif ($revision_or_hash =~ /^r\\d+$/) {\n \t\tmy $head = shift;\n-- \n1.5.4.4.482.ga8b1\n"},{"id":"71667","messageId":"e29894ca0803110104g62cda988vf933349995673afd@mail.gmail.com","threadId":"12627","inReplyTo":"20080311051910.GB9389@hand.yhbt.net","subject":"Re: [PATCH] git-svn: find-rev error message when missing arg","fromName":"Marc-André Lureau","fromEmail":"marcandre.lureau@gmail.com","sentAt":"2008-03-11T08:04:55Z","receivedAt":"2008-03-11T08:04:55Z","isPatch":true,"sender":{"key":"marcandre.lureau@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9381?v=4"},"body":"hi,\n\nOn Tue, Mar 11, 2008 at 7:19 AM, Eric Wong wrote:\n>\n> * Minor spelling error noted below.\n> * Please wrap your commit message lines at 72 characters or less.\n> * Sign-off?\n>\n> Tentatively-Acked-by: Eric Wong \n\noups, I was too tired, I hope this second patch is fine.\nThanks for reviewing :)\n\nRegards,\n\n-- \nMarc-André Lureau\n"},{"id":"71753","messageId":"20080311204606.GC9389@hand.yhbt.net","threadId":"12627","inReplyTo":"e29894ca0803110104g62cda988vf933349995673afd@mail.gmail.com","subject":"Re: [PATCH] git-svn: find-rev error message when missing arg","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2008-03-11T20:46:06Z","receivedAt":"2008-03-11T20:46:06Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Marc-André Lureau wrote:\n> hi,\n> \n> On Tue, Mar 11, 2008 at 7:19 AM, Eric Wong wrote:\n> >\n> > * Minor spelling error noted below.\n> > * Please wrap your commit message lines at 72 characters or less.\n> > * Sign-off?\n> >\n> > Tentatively-Acked-by: Eric Wong \n> \n> oups, I was too tired, I hope this second patch is fine.\n> Thanks for reviewing :)\n\nThanks for the patch and fixes Mark André\n\nAcked-by: Eric Wong \n\n-- \nEric Wong\n"}]}