threads / discuss / 12434

git-filter-branch may leave tree in a nasty state

Subject: git-filter-branch may leave tree in a nasty state

## tl;dr

3 messages between Mar 2, 2008 and Mar 2, 2008.

replies: 2people: 2as markdown or json

Jan Engelhardt· Mar 2, 2008, 19:31 UTC · lore
Hi,

$ git-filter-branch --env-filter 'export GIT_AUTHOR_NAME="";' b4caa441..HEAD Rewrite cf1d02ac074041f7e570ff206d87fb47ef2b2c34 (1/1)fatal: empty ident <user@corp.com> not allowed

Ref 'refs/heads/master' was deleted fatal: Not a valid object name HEAD

$ git log fatal: bad default revision 'HEAD'

Johannes Schindelin· Mar 2, 2008, 20:40 UTC · re: Jan Engelhardt · lore

Re: git-filter-branch may leave tree in a nasty state

Hi,
On Sun, 2 Mar 2008, Jan Engelhardt wrote:
> $ git-filter-branch --env-filter 'export GIT_AUTHOR_NAME="";' b4caa441..HEAD
> Rewrite cf1d02ac074041f7e570ff206d87fb47ef2b2c34 (1/1)fatal: empty ident  
> <user@corp.com> not allowed

Well, I kinda expected people savvy enough to run filter-branch to have set up the proper ident ;-)

Ciao, Dscho

Jan Engelhardt· Mar 2, 2008, 21:02 UTC · re: Johannes Schindelin · lore

Re: git-filter-branch may leave tree in a nasty state

On Mar 2 2008 20:40, Johannes Schindelin wrote:
Show 8 quoted lines
>On Sun, 2 Mar 2008, Jan Engelhardt wrote:
>
>> $ git-filter-branch --env-filter 'export GIT_AUTHOR_NAME="";' b4caa441..HEAD
>> Rewrite cf1d02ac074041f7e570ff206d87fb47ef2b2c34 (1/1)fatal: empty ident  
>> <user@corp.com> not allowed
>
>Well, I kinda expected people savvy enough to run filter-branch to have 
>set up the proper ident ;-)

Nah, this is just the test case. The real scripts I use write author, email and log message to a file in the env-filter hook, call an editor where they can be arbitrarily changed, and then the rest of the env-filter and msg-filter hooks parse the text file back into the shell variables.

So I am changing the ident of existing commits (postprocessing a non-git tree conversion).

The problem is that some editors clear the terminal window (in other words, they are "full-screen"), so I did not get to see the filter-branch error message at all because the next editor invocation just popped in.

Most importantly, git-filter-branch should STOP when it detects a problem, not try rewriting the next commit.

← back to recent threads