threads / bug / 12348

Minor bug in 'stg edit' ?

Subject: Minor bug in 'stg edit' ?

## tl;dr

5 messages between Feb 27, 2008 and Feb 29, 2008.

replies: 4people: 3as markdown or json

Paul Donohue· Feb 27, 2008, 22:47 UTC · lore

I'm running StGIT 0.14.1

After running 'stg edit', the file '.stgit-edit.txt' is always left behind.

Is this supposed to happen?  I would have assumed the file would be automatically removed after the changes were committed.

Thanks! -Paul

Karl Hasselström· Feb 28, 2008, 09:41 UTC · re: Paul Donohue · lore

Re: Minor bug in 'stg edit' ?

On 2008-02-27 17:47:57 -0500, Paul Donohue wrote:

> After running 'stg edit', the file '.stgit-edit.txt' is always left
> behind. Is this supposed to happen? I would have assumed the file
> would be automatically removed after the changes were committed.

Yes, I'd say that's a bug.

> I'm running StGIT 0.14.1.

The bug is gone in the master branch (at least as far as I can tell); it probably disappeared when stg edit was switched to the new infrastructure.

> Thanks!

Thanks for the bug report.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle

Catalin Marinas· Feb 28, 2008, 21:43 UTC · re: Paul Donohue · lore

Re: Minor bug in 'stg edit' ?

On 27/02/2008, Paul Donohue <stgit-bug@topquark.net> wrote:

Show 5 quoted lines

> I'm running StGIT 0.14.1
>
>  After running 'stg edit', the file '.stgit-edit.txt' is always left behind.
>
>  Is this supposed to happen?  I would have assumed the file would be automatically removed after the changes were committed.

I wouldn't say it's a bug as I never thought it would cause any problems if left. Anyway, we could remove it if the operation was successful.

-- 
Catalin

Paul Donohue· Feb 28, 2008, 21:54 UTC · re: Catalin Marinas · lore

Re: Minor bug in 'stg edit' ?

The only problem it causes is that it shows up as an untracked file if you run 'git status'

I guess this doesn't really matter since you should be using 'stg status' instead, but 'git status' supports colors, so I generally use that instead of 'stg status', since I can interpret the colored output slightly faster than I can scan for ? flags when I want to know if I need to 'stg add' any files before I 'stg refresh'...

Thanks. -Paul

On Thu, Feb 28, 2008 at 09:43:53PM +0000, Catalin Marinas wrote:

Show 14 quoted lines

> On 27/02/2008, Paul Donohue <stgit-bug@topquark.net> wrote:
> > I'm running StGIT 0.14.1
> >
> >  After running 'stg edit', the file '.stgit-edit.txt' is always left behind.
> >
> >  Is this supposed to happen?  I would have assumed the file would be automatically removed after the changes were committed.
> 
> I wouldn't say it's a bug as I never thought it would cause any
> problems if left. Anyway, we could remove it if the operation was
> successful.
> 
> -- 
> Catalin
>

Karl Hasselström· Feb 29, 2008, 08:00 UTC · re: Paul Donohue · lore

Re: Minor bug in 'stg edit' ?

On 2008-02-28 16:54:15 -0500, Paul Donohue wrote:

> The only problem it causes is that it shows up as an untracked file
> if you run 'git status'

I put ".stgit*" in my ~/.gitignore ages ago. :-)

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle