threads / patch / 12303

patch, 3 partsshow alias definitions in help

Subject: [PATCH 0/3] show alias definitions in help

## tl;dr

3 messages between Feb 24, 2008 and Feb 25, 2008. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Jeff King· Feb 24, 2008, 22:16 UTC · lore

This was requested during the freeze period, and I posted a "like this?" patch with a promise to follow-up post-1.5.4. So here is the follow-up.

The objections to my quick patch were:

  - (Dscho) the parsing code was ugly and needed cleanup; the first
    patch refactors cmd_help to use parseopt
  - (Duy) help lookup should respect the usual "commands before alias"
    rule that we use for execution; the third patch takes this into
    account

      1/3: help: use parseopt
           This is parseopt plus general cleanup.

      2/3: make alias lookup a public, procedural function
           Another cleanup to factor out alias lookup from git.c (which
           we will also need in help now).

      help: respect aliases
           The actual patch.

 Makefile |    3 +-
 alias.c  |   22 +++++++++
 cache.h  |    2 +
 git.c    |   17 +------
 help.c   |  152 ++++++++++++++++++++++++++++++++++++--------------------------
 5 files changed, 118 insertions(+), 78 deletions(-)
 create mode 100644 alias.c

Jeff King· Feb 24, 2008, 22:23 UTC · re: Jeff King · lore

Re: [PATCH 0/3] show alias definitions in help

On Sun, Feb 24, 2008 at 05:16:00PM -0500, Jeff King wrote:

Show 7 quoted lines

>  Makefile |    3 +-
>  alias.c  |   22 +++++++++
>  cache.h  |    2 +
>  git.c    |   17 +------
>  help.c   |  152 ++++++++++++++++++++++++++++++++++++--------------------
>  5 files changed, 118 insertions(+), 78 deletions(-)
>  create mode 100644 alias.c

BTW, Daniel, I have used your --cover-letter work several times today, and it is terrific. It has saved me a lot of error-prone cutting and pasting of message-ids and commit titles. Thanks.

-Peff

Daniel Barkalow· Feb 25, 2008, 16:47 UTC · re: Jeff King · lore

Re: [PATCH 0/3] show alias definitions in help

On Sun, 24 Feb 2008, Jeff King wrote:

> BTW, Daniel, I have used your --cover-letter work several times today,
> and it is terrific. It has saved me a lot of error-prone cutting and
> pasting of message-ids and commit titles. Thanks.

Great to hear. Let me know if you have any suggestions to improve it; I haven't been using it all that much, since I got it into my installed git approximately when I'd just cleared my table of long series, so you may come up with obvious lacks before I do.

	-Daniel
*This .sig left intentionally blank*