{"thread":{"id":"12303","subject":"[PATCH 0/3] show alias definitions in help","startedAt":"2008-02-24T22:16:00Z","lastAt":"2008-02-25T16:47:19Z","messageCount":3,"participants":["Jeff King","Daniel Barkalow"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"69824","messageId":"20080224221559.GA31309@coredump.intra.peff.net","threadId":"12303","inReplyTo":null,"subject":"[PATCH 0/3] show alias definitions in help","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-02-24T22:16:00Z","receivedAt":"2008-02-24T22:16:00Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"This was requested during the freeze period, and I posted a \"like this?\"\npatch with a promise to follow-up post-1.5.4. So here is the follow-up.\n\nThe objections to my quick patch were:\n\n  - (Dscho) the parsing code was ugly and needed cleanup; the first\n    patch refactors cmd_help to use parseopt\n  - (Duy) help lookup should respect the usual \"commands before alias\"\n    rule that we use for execution; the third patch takes this into\n    account\n\n      1/3: help: use parseopt\n           This is parseopt plus general cleanup.\n\n      2/3: make alias lookup a public, procedural function\n           Another cleanup to factor out alias lookup from git.c (which\n           we will also need in help now).\n\n      help: respect aliases\n           The actual patch.\n\n Makefile |    3 +-\n alias.c  |   22 +++++++++\n cache.h  |    2 +\n git.c    |   17 +------\n help.c   |  152 ++++++++++++++++++++++++++++++++++++--------------------------\n 5 files changed, 118 insertions(+), 78 deletions(-)\n create mode 100644 alias.c\n"},{"id":"69828","messageId":"20080224222331.GA6712@coredump.intra.peff.net","threadId":"12303","inReplyTo":"20080224221559.GA31309@coredump.intra.peff.net","subject":"Re: [PATCH 0/3] show alias definitions in help","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2008-02-24T22:23:31Z","receivedAt":"2008-02-24T22:23:31Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Feb 24, 2008 at 05:16:00PM -0500, Jeff King wrote:\n\n>  Makefile |    3 +-\n>  alias.c  |   22 +++++++++\n>  cache.h  |    2 +\n>  git.c    |   17 +------\n>  help.c   |  152 ++++++++++++++++++++++++++++++++++++--------------------\n>  5 files changed, 118 insertions(+), 78 deletions(-)\n>  create mode 100644 alias.c\n\nBTW, Daniel, I have used your --cover-letter work several times today,\nand it is terrific. It has saved me a lot of error-prone cutting and\npasting of message-ids and commit titles. Thanks.\n\n-Peff\n"},{"id":"69892","messageId":"alpine.LNX.1.00.0802251136190.19024@iabervon.org","threadId":"12303","inReplyTo":"20080224222331.GA6712@coredump.intra.peff.net","subject":"Re: [PATCH 0/3] show alias definitions in help","fromName":"Daniel Barkalow","fromEmail":"barkalow@iabervon.org","sentAt":"2008-02-25T16:47:19Z","receivedAt":"2008-02-25T16:47:19Z","isPatch":true,"sender":{"key":"barkalow@iabervon.org","avatar":"https://avatars.githubusercontent.com/u/55364219?v=4"},"body":"\nOn Sun, 24 Feb 2008, Jeff King wrote:\n\n> BTW, Daniel, I have used your --cover-letter work several times today,\n> and it is terrific. It has saved me a lot of error-prone cutting and\n> pasting of message-ids and commit titles. Thanks.\n\nGreat to hear. Let me know if you have any suggestions to improve it; I \nhaven't been using it all that much, since I got it into my installed git \napproximately when I'd just cleared my table of long series, so you may \ncome up with obvious lacks before I do.\n\n\t-Daniel\n*This .sig left intentionally blank*\n"}]}