threads / patch / 11878

patch, 9 partsSend unpack-trees debugging output to stderr

Subject: [PATCH 3/9] Send unpack-trees debugging output to stderr

## tl;dr

3 messages between Feb 4, 2008 and Feb 5, 2008. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Daniel Barkalow· Feb 4, 2008, 18:35 UTC · lore

This is to keep git-stash from getting confused if you're debugging unpack-trees.

Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
---
 unpack-trees.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

Show changes to unpack-trees.c +7 −7

diff --git a/unpack-trees.c b/unpack-trees.c
index 45f40c2..f462a56 100644
--- a/unpack-trees.c
+++ b/unpack-trees.c
@@ -122,13 +122,13 @@ static int unpack_trees_rec(struct tree_entry_list **posns, int len,
 
 #if DBRT_DEBUG > 1
 		if (first)
-			printf("index %s\n", first);
+			fprintf(stderr, "index %s\n", first);
 #endif
 		for (i = 0; i < len; i++) {
 			if (!posns[i] || posns[i] == df_conflict_list)
 				continue;
 #if DBRT_DEBUG > 1
-			printf("%d %s\n", i + 1, posns[i]->name);
+			fprintf(stderr, "%d %s\n", i + 1, posns[i]->name);
 #endif
 			if (!first || entcmp(first, firstdir,
 					     posns[i]->name,
@@ -209,13 +209,13 @@ static int unpack_trees_rec(struct tree_entry_list **posns, int len,
 				int ret;
 
 #if DBRT_DEBUG > 1
-				printf("%s:\n", first);
+				fprintf(stderr, "%s:\n", first);
 				for (i = 0; i < src_size; i++) {
-					printf(" %d ", i);
+					fprintf(stderr, " %d ", i);
 					if (src[i])
-						printf("%s\n", sha1_to_hex(src[i]->sha1));
+						fprintf(stderr, "%06x %s\n", src[i]->ce_mode, sha1_to_hex(src[i]->sha1));
 					else
-						printf("\n");
+						fprintf(stderr, "\n");
 				}
 #endif
 				ret = o->fn(src, o, remove);
@@ -223,7 +223,7 @@ static int unpack_trees_rec(struct tree_entry_list **posns, int len,
 					return ret;
 
 #if DBRT_DEBUG > 1
-				printf("Added %d entries\n", ret);
+				fprintf(stderr, "Added %d entries\n", ret);
 #endif
 				o->pos += ret;
 			} else {

-- 
1.5.4

Johannes Schindelin· Feb 5, 2008, 01:20 UTC · re: Daniel Barkalow · lore

Re: [PATCH 3/9] Send unpack-trees debugging output to stderr

Hi,

On Mon, 4 Feb 2008, Daniel Barkalow wrote:

Show 5 quoted lines

>  #if DBRT_DEBUG > 1
>  		if (first)
> -			printf("index %s\n", first);
> +			fprintf(stderr, "index %s\n", first);
>  #endif

This code path is only affected when DBRT_DEBUG is defined ("Daniel Barkalow's Roasted Tomatoes"?). So technically, I do not really see why this is part of this patch series...

Ciao, Dscho

Daniel Barkalow· Feb 5, 2008, 20:38 UTC · re: Johannes Schindelin · lore

Re: [PATCH 3/9] Send unpack-trees debugging output to stderr

On Tue, 5 Feb 2008, Johannes Schindelin wrote:

Show 13 quoted lines

> Hi,
> 
> On Mon, 4 Feb 2008, Daniel Barkalow wrote:
> 
> >  #if DBRT_DEBUG > 1
> >  		if (first)
> > -			printf("index %s\n", first);
> > +			fprintf(stderr, "index %s\n", first);
> >  #endif
> 
> This code path is only affected when DBRT_DEBUG is defined ("Daniel 
> Barkalow's Roasted Tomatoes"?).  So technically, I do not really see why 
> this is part of this patch series...

"Daniel Barkalow's read_tree" (which is what that code was called when it was added). I needed to enable this debugging in order to debug this series, and found that enabling debugging caused tests to fail, so I fixed that in the series. To the extent that this matters at all, having it in the series that could need debugging makes sense.

	-Daniel
*This .sig left intentionally blank*