# [PATCH 3/9] Send unpack-trees debugging output to stderr 3 messages from 2008-02-04 to 2008-02-05. Participants: Daniel Barkalow, Johannes Schindelin. Thread: https://gitlist.dev/t/11878 ## Daniel Barkalow, 2008-02-04 18:35 Subject: [PATCH 3/9] Send unpack-trees debugging output to stderr Message-ID: URL: https://gitlist.dev/e/alpine.LNX.1.00.0802041335430.13593%40iabervon.org ``` This is to keep git-stash from getting confused if you're debugging unpack-trees. Signed-off-by: Daniel Barkalow --- unpack-trees.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/unpack-trees.c b/unpack-trees.c index 45f40c2..f462a56 100644 --- a/unpack-trees.c +++ b/unpack-trees.c @@ -122,13 +122,13 @@ static int unpack_trees_rec(struct tree_entry_list **posns, int len, #if DBRT_DEBUG > 1 if (first) - printf("index %s\n", first); + fprintf(stderr, "index %s\n", first); #endif for (i = 0; i < len; i++) { if (!posns[i] || posns[i] == df_conflict_list) continue; #if DBRT_DEBUG > 1 - printf("%d %s\n", i + 1, posns[i]->name); + fprintf(stderr, "%d %s\n", i + 1, posns[i]->name); #endif if (!first || entcmp(first, firstdir, posns[i]->name, @@ -209,13 +209,13 @@ static int unpack_trees_rec(struct tree_entry_list **posns, int len, int ret; #if DBRT_DEBUG > 1 - printf("%s:\n", first); + fprintf(stderr, "%s:\n", first); for (i = 0; i < src_size; i++) { - printf(" %d ", i); + fprintf(stderr, " %d ", i); if (src[i]) - printf("%s\n", sha1_to_hex(src[i]->sha1)); + fprintf(stderr, "%06x %s\n", src[i]->ce_mode, sha1_to_hex(src[i]->sha1)); else - printf("\n"); + fprintf(stderr, "\n"); } #endif ret = o->fn(src, o, remove); @@ -223,7 +223,7 @@ static int unpack_trees_rec(struct tree_entry_list **posns, int len, return ret; #if DBRT_DEBUG > 1 - printf("Added %d entries\n", ret); + fprintf(stderr, "Added %d entries\n", ret); #endif o->pos += ret; } else { -- 1.5.4 ``` ## Johannes Schindelin, 2008-02-05 01:20 Subject: Re: [PATCH 3/9] Send unpack-trees debugging output to stderr Message-ID: URL: https://gitlist.dev/e/alpine.LSU.1.00.0802050117410.8543%40racer.site In-Reply-To: ``` Hi, On Mon, 4 Feb 2008, Daniel Barkalow wrote: > #if DBRT_DEBUG > 1 > if (first) > - printf("index %s\n", first); > + fprintf(stderr, "index %s\n", first); > #endif This code path is only affected when DBRT_DEBUG is defined ("Daniel Barkalow's Roasted Tomatoes"?). So technically, I do not really see why this is part of this patch series... Ciao, Dscho ``` ## Daniel Barkalow, 2008-02-05 20:38 Subject: Re: [PATCH 3/9] Send unpack-trees debugging output to stderr Message-ID: URL: https://gitlist.dev/e/alpine.LNX.1.00.0802042118420.13593%40iabervon.org In-Reply-To: ``` On Tue, 5 Feb 2008, Johannes Schindelin wrote: > Hi, > > On Mon, 4 Feb 2008, Daniel Barkalow wrote: > > > #if DBRT_DEBUG > 1 > > if (first) > > - printf("index %s\n", first); > > + fprintf(stderr, "index %s\n", first); > > #endif > > This code path is only affected when DBRT_DEBUG is defined ("Daniel > Barkalow's Roasted Tomatoes"?). So technically, I do not really see why > this is part of this patch series... "Daniel Barkalow's read_tree" (which is what that code was called when it was added). I needed to enable this debugging in order to debug this series, and found that enabling debugging caused tests to fail, so I fixed that in the series. To the extent that this matters at all, having it in the series that could need debugging makes sense. -Daniel *This .sig left intentionally blank* ```