threads / patch / 11538

patchchange usage string of refresh to not refer to removed options

Subject: [STG PATCH] change usage string of refresh to not refer to removed options

## tl;dr

2 messages between Jan 8, 2008 and Jan 9, 2008. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Peter Oberndorfer· Jan 8, 2008, 20:43 UTC · lore
for changing the patch author, commiter and description
Signed-off-by: Peter Oberndorfer <kumbayo84@arcor.de>
---

I saw this while doing the refresh --index patch. There was a discussion about bringing back refresh -e If that also brings back this options, please do not apply the patch:-)

 stgit/commands/refresh.py |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)
Show changes to stgit/commands/refresh.py +3 −5
diff --git a/stgit/commands/refresh.py b/stgit/commands/refresh.py
index 952b1b6..4695c62 100644
--- a/stgit/commands/refresh.py
+++ b/stgit/commands/refresh.py
@@ -31,11 +31,9 @@ usage = """%prog [options] [<files or dirs>]
 
 Include the latest tree changes in the current patch. This command
 generates a new GIT commit object with the patch details, the previous
-one no longer being visible. The patch attributes like author,
-committer and description can be changed with the command line
-options. The '--force' option is useful when a commit object was
-created with a different tool but the changes need to be included in
-the current patch."""
+one no longer being visible. The '--force' option is useful
+when a commit object was created with a different tool
+but the changes need to be included in the current patch."""
 
 directory = DirectoryHasRepository()
 options = [make_option('-f', '--force',
-- 
1.5.4.rc2
Karl Hasselström· Jan 9, 2008, 07:20 UTC · re: Peter Oberndorfer · lore

Re: [STG PATCH] change usage string of refresh to not refer to removed options

Thanks! But ...
On 2008-01-08 21:43:53 +0100, Peter Oberndorfer wrote:
> for changing the patch author, commiter and description

the first line in the commit message (which ends up being the Subject: line in the mail) should be a short and self-contained summary. No need to resend just because of that, though -- I can fix it up.

> I saw this while doing the refresh --index patch. There was a
> discussion about bringing back refresh -e If that also brings back
> this options, please do not apply the patch:-)

Resurrecting "refresh -e" is on my todo list. But until then, this is a good fix.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle

← back to recent threads