threads / patch / 11337

patchfilter-branch: Remove broken and unnecessary summary of rewritten refs.

Subject: [PATCH] filter-branch: Remove broken and unnecessary summary of rewritten refs.

## tl;dr

3 messages between Dec 18, 2007 and Dec 18, 2007. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Johannes Sixt· Dec 18, 2007, 07:30 UTC · lore

There was an attempt to list the refs that were rewritten by filtering the output of 'git show-ref' for 'refs/original'. But it got the grep argument wrong, which did not account for the SHA1 that is listed before the ref.

Moreover, right before this summary is the loop that actually does the rewriting, and the rewritten refs are listed there anyway. So this extra summary is plainly too verbose.

Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
---
 git-filter-branch.sh |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
Show changes to git-filter-branch.sh +0 −3
diff --git a/git-filter-branch.sh b/git-filter-branch.sh
index 29d35fd..e730897 100755
--- a/git-filter-branch.sh
+++ b/git-filter-branch.sh
@@ -423,9 +423,6 @@ fi
 
 cd ../..
 rm -rf "$tempdir"
-echo
-test $count -gt 0 && echo "These refs were rewritten:"
-git show-ref | grep ^"$orig_namespace"
 
 unset GIT_DIR GIT_WORK_TREE GIT_INDEX_FILE
 test -z "$ORIG_GIT_DIR" || GIT_DIR="$ORIG_GIT_DIR" && export GIT_DIR

-- 
1.5.4.rc0.73.gcaffa
Johannes Sixt· Dec 18, 2007, 11:21 UTC · re: Junio C Hamano · lore

Re: [PATCH] filter-branch: Remove broken and unnecessary summary of rewritten refs.

Junio C Hamano schrieb:
> Sounds sensible.  Applied.

It seems lately I can't get a thing right on the first try. Would you please squash this in as long as you haven't pushed out the commit? $count is now unused.

Thank you!
--- >8 ---
Show changes to git-filter-branch.sh +0 −2
diff --git a/git-filter-branch.sh b/git-filter-branch.sh
index e730897..f8bdc14 100755
--- a/git-filter-branch.sh
+++ b/git-filter-branch.sh
@@ -342,7 +342,6 @@ done < "$tempdir"/heads

 _x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'
 _x40="$_x40$_x40$_x40$_x40$_x40$_x40$_x40$_x40"
-count=0
 echo
 while read ref
 do
@@ -380,7 +379,6 @@ do
 	;;
 	esac
 	git update-ref -m "filter-branch: backup" "$orig_namespace$ref" $sha1
-	count=$(($count+1))
 done < "$tempdir"/heads

 # TODO: This should possibly go, with the semantics that all positive given

← back to recent threads