{"thread":{"id":"11337","subject":"[PATCH] filter-branch: Remove broken and unnecessary summary of rewritten refs.","startedAt":"2007-12-18T07:30:47Z","lastAt":"2007-12-18T11:21:18Z","messageCount":3,"participants":["Johannes Sixt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"63565","messageId":"1197963047-15930-1-git-send-email-johannes.sixt@telecom.at","threadId":"11337","inReplyTo":null,"subject":"[PATCH] filter-branch: Remove broken and unnecessary summary of rewritten refs.","fromName":"Johannes Sixt","fromEmail":"johannes.sixt@telecom.at","sentAt":"2007-12-18T07:30:47Z","receivedAt":"2007-12-18T07:30:47Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"There was an attempt to list the refs that were rewritten by filtering\nthe output of 'git show-ref' for 'refs/original'. But it got the\ngrep argument wrong, which did not account for the SHA1 that is listed\nbefore the ref.\n\nMoreover, right before this summary is the loop that actually does the\nrewriting, and the rewritten refs are listed there anyway. So this extra\nsummary is plainly too verbose.\n\nSigned-off-by: Johannes Sixt <johannes.sixt@telecom.at>\n---\n git-filter-branch.sh |    3 ---\n 1 files changed, 0 insertions(+), 3 deletions(-)\n\ndiff --git a/git-filter-branch.sh b/git-filter-branch.sh\nindex 29d35fd..e730897 100755\n--- a/git-filter-branch.sh\n+++ b/git-filter-branch.sh\n@@ -423,9 +423,6 @@ fi\n \n cd ../..\n rm -rf \"$tempdir\"\n-echo\n-test $count -gt 0 && echo \"These refs were rewritten:\"\n-git show-ref | grep ^\"$orig_namespace\"\n \n unset GIT_DIR GIT_WORK_TREE GIT_INDEX_FILE\n test -z \"$ORIG_GIT_DIR\" || GIT_DIR=\"$ORIG_GIT_DIR\" && export GIT_DIR\n-- \n1.5.4.rc0.73.gcaffa\n"},{"id":"63582","messageId":"7vejdk1g3h.fsf@gitster.siamese.dyndns.org","threadId":"11337","inReplyTo":"1197963047-15930-1-git-send-email-johannes.sixt@telecom.at","subject":"Re: [PATCH] filter-branch: Remove broken and unnecessary summary of rewritten refs.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-18T09:56:18Z","receivedAt":"2007-12-18T09:56:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sounds sensible.  Applied.\n"},{"id":"63592","messageId":"4767AD2E.4040906@viscovery.net","threadId":"11337","inReplyTo":"7vejdk1g3h.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] filter-branch: Remove broken and unnecessary summary of rewritten refs.","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2007-12-18T11:21:18Z","receivedAt":"2007-12-18T11:21:18Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Junio C Hamano schrieb:\n> Sounds sensible.  Applied.\n\nIt seems lately I can't get a thing right on the first try. Would you please\nsquash this in as long as you haven't pushed out the commit? $count is\nnow unused.\n\nThank you!\n\n--- >8 ---\n\ndiff --git a/git-filter-branch.sh b/git-filter-branch.sh\nindex e730897..f8bdc14 100755\n--- a/git-filter-branch.sh\n+++ b/git-filter-branch.sh\n@@ -342,7 +342,6 @@ done < \"$tempdir\"/heads\n\n _x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'\n _x40=\"$_x40$_x40$_x40$_x40$_x40$_x40$_x40$_x40\"\n-count=0\n echo\n while read ref\n do\n@@ -380,7 +379,6 @@ do\n \t;;\n \tesac\n \tgit update-ref -m \"filter-branch: backup\" \"$orig_namespace$ref\" $sha1\n-\tcount=$(($count+1))\n done < \"$tempdir\"/heads\n\n # TODO: This should possibly go, with the semantics that all positive given\n"}]}