threads / discuss / 11292

StGIT: "stg refresh -e/--edit" to refresh patch and edit description no longer works

Subject: StGIT: "stg refresh -e/--edit" to refresh patch and edit description no longer works

## tl;dr

3 messages between Dec 14, 2007 and Dec 14, 2007.

replies: 2people: 2as markdown or json

Jakub Narebski· Dec 14, 2007, 14:07 UTC · lore

The command I used quite often in my StGIT workflow, namely "stg refresh -e", which used to refresh patch and launch editor to edit commit (patch) description no longer works in Stacked GIT 0.14.1.

I used it when new (refreshed) changes needed also changes in commit description (commit message). Now I have to run two commands: "stg refresh" and "stg edit".

-- 
Jakub Narebski
Poland

Catalin Marinas· Dec 14, 2007, 14:26 UTC · re: Jakub Narebski · lore

Re: StGIT: "stg refresh -e/--edit" to refresh patch and edit description no longer works

On 14/12/2007, Jakub Narebski <jnareb@gmail.com> wrote:

Show 7 quoted lines

> The command I used quite often in my StGIT workflow, namely
> "stg refresh -e", which used to refresh patch and launch editor to edit
> commit (patch) description no longer works in Stacked GIT 0.14.1.
>
> I used it when new (refreshed) changes needed also changes in commit
> description (commit message). Now I have to run two commands:
> "stg refresh" and "stg edit".

Well, people complained that 'refresh -e' is misleading and a separate command is needed. It's not difficult to move the editing functionality out of stgit.commands.edit and re-add the --edit option to refresh (while also keeping the separate edit command).

I'm a bit busy with home/family commitments until the new year.

-- 
Catalin

Jakub Narebski· Dec 14, 2007, 16:01 UTC · re: Catalin Marinas · lore

Re: StGIT: "stg refresh -e/--edit" to refresh patch and edit description no longer works

On Fri, 14 Dec 2007, Catalin Marinas wrote:

Show 14 quoted lines

> On 14/12/2007, Jakub Narebski <jnareb@gmail.com> wrote:
>>
>> The command I used quite often in my StGIT workflow, namely
>> "stg refresh -e", which used to refresh patch and launch editor to edit
>> commit (patch) description no longer works in Stacked GIT 0.14.1.
>>
>> I used it when new (refreshed) changes needed also changes in commit
>> description (commit message). Now I have to run two commands:
>> "stg refresh" and "stg edit".
> 
> Well, people complained that 'refresh -e' is misleading and a separate
> command is needed. It's not difficult to move the editing
> functionality out of stgit.commands.edit and re-add the --edit option
> to refresh (while also keeping the separate edit command).

First, the "misleading" part could be corrected by renaming long option to --edit-description or --edit-message. Second "stg refresh -e" matches non-StGIT usage of "git commit --amend"; and it is damn useful to have it as one command, not two.

> I'm a bit busy with home/family commitments until the new year.

I'll wait. As I am not running StGIT master, but released version, I would have to waith nevertheless on next release.

TIA

-- 
Jakub Narebski
Poland