{"thread":{"id":"11292","subject":"StGIT: \"stg refresh -e/--edit\" to refresh patch and edit description no longer works","startedAt":"2007-12-14T14:07:00Z","lastAt":"2007-12-14T16:01:42Z","messageCount":3,"participants":["Jakub Narebski","Catalin Marinas"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"63168","messageId":"200712141507.01552.jnareb@gmail.com","threadId":"11292","inReplyTo":null,"subject":"StGIT: \"stg refresh -e/--edit\" to refresh patch and edit description no longer works","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-12-14T14:07:00Z","receivedAt":"2007-12-14T14:07:00Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"The command I used quite often in my StGIT workflow, namely \n\"stg refresh -e\", which used to refresh patch and launch editor to edit \ncommit (patch) description no longer works in Stacked GIT 0.14.1.\n\nI used it when new (refreshed) changes needed also changes in commit \ndescription (commit message). Now I have to run two commands: \n\"stg refresh\" and \"stg edit\".\n\n-- \nJakub Narebski\nPoland\n"},{"id":"63170","messageId":"b0943d9e0712140626w3a2f55b1i83c33f93d7f8af2f@mail.gmail.com","threadId":"11292","inReplyTo":"200712141507.01552.jnareb@gmail.com","subject":"Re: StGIT: \"stg refresh -e/--edit\" to refresh patch and edit description no longer works","fromName":"Catalin Marinas","fromEmail":"catalin.marinas@gmail.com","sentAt":"2007-12-14T14:26:40Z","receivedAt":"2007-12-14T14:26:40Z","isPatch":false,"sender":{"key":"catalin.marinas@gmail.com","avatar":null},"body":"On 14/12/2007, Jakub Narebski <jnareb@gmail.com> wrote:\n> The command I used quite often in my StGIT workflow, namely\n> \"stg refresh -e\", which used to refresh patch and launch editor to edit\n> commit (patch) description no longer works in Stacked GIT 0.14.1.\n>\n> I used it when new (refreshed) changes needed also changes in commit\n> description (commit message). Now I have to run two commands:\n> \"stg refresh\" and \"stg edit\".\n\nWell, people complained that 'refresh -e' is misleading and a separate\ncommand is needed. It's not difficult to move the editing\nfunctionality out of stgit.commands.edit and re-add the --edit option\nto refresh (while also keeping the separate edit command).\n\nI'm a bit busy with home/family commitments until the new year.\n\n-- \nCatalin\n"},{"id":"63173","messageId":"200712141701.43914.jnareb@gmail.com","threadId":"11292","inReplyTo":"b0943d9e0712140626w3a2f55b1i83c33f93d7f8af2f@mail.gmail.com","subject":"Re: StGIT: \"stg refresh -e/--edit\" to refresh patch and edit description no longer works","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-12-14T16:01:42Z","receivedAt":"2007-12-14T16:01:42Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Fri, 14 Dec 2007, Catalin Marinas wrote:\n> On 14/12/2007, Jakub Narebski <jnareb@gmail.com> wrote:\n>>\n>> The command I used quite often in my StGIT workflow, namely\n>> \"stg refresh -e\", which used to refresh patch and launch editor to edit\n>> commit (patch) description no longer works in Stacked GIT 0.14.1.\n>>\n>> I used it when new (refreshed) changes needed also changes in commit\n>> description (commit message). Now I have to run two commands:\n>> \"stg refresh\" and \"stg edit\".\n> \n> Well, people complained that 'refresh -e' is misleading and a separate\n> command is needed. It's not difficult to move the editing\n> functionality out of stgit.commands.edit and re-add the --edit option\n> to refresh (while also keeping the separate edit command).\n\nFirst, the \"misleading\" part could be corrected by renaming long option\nto --edit-description or --edit-message. Second \"stg refresh -e\" matches\nnon-StGIT usage of \"git commit --amend\"; and it is damn useful to have\nit as one command, not two. \n\n> I'm a bit busy with home/family commitments until the new year.\n\nI'll wait. As I am not running StGIT master, but released version,\nI would have to waith nevertheless on next release.\n\nTIA\n-- \nJakub Narebski\nPoland\n"}]}