threads / patch / 11032

patcht7003-filter-branch: Fix test of a failing --msg-filter.

Subject: [PATCH] t7003-filter-branch: Fix test of a failing --msg-filter.

## tl;dr

One message between Nov 27, 2007 and Nov 27, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Johannes Sixt· Nov 27, 2007, 12:10 UTC · lore

The test passed for the wrong reason: If the script given to --msg-filter fails, it is expected that git-filter-branch aborts. But the test forgot to tell the branch name to rewrite, and so git-filter-branch failed due to incorrect usage.

Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
---
 t/t7003-filter-branch.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to t/t7003-filter-branch.sh +1 −1
diff --git a/t/t7003-filter-branch.sh b/t/t7003-filter-branch.sh
index 2089351..5f60b22 100755
--- a/t/t7003-filter-branch.sh
+++ b/t/t7003-filter-branch.sh
@@ -114,7 +114,7 @@ test_expect_success 'use index-filter to move into a subdirectory' '
 
 test_expect_success 'stops when msg filter fails' '
 	old=$(git rev-parse HEAD) &&
-	! git-filter-branch -f --msg-filter false &&
+	! git-filter-branch -f --msg-filter false HEAD &&
 	test $old = $(git rev-parse HEAD) &&
 	rm -rf .git-rewrite
 '
-- 
1.5.3.6.967.ga9b45

← back to recent threads