{"thread":{"id":"11032","subject":"[PATCH] t7003-filter-branch: Fix test of a failing --msg-filter.","startedAt":"2007-11-27T12:10:19Z","lastAt":"2007-11-27T12:10:19Z","messageCount":1,"participants":["Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"61062","messageId":"1196165419-10201-1-git-send-email-johannes.sixt@telecom.at","threadId":"11032","inReplyTo":null,"subject":"[PATCH] t7003-filter-branch: Fix test of a failing --msg-filter.","fromName":"Johannes Sixt","fromEmail":"johannes.sixt@telecom.at","sentAt":"2007-11-27T12:10:19Z","receivedAt":"2007-11-27T12:10:19Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"The test passed for the wrong reason: If the script given to --msg-filter\nfails, it is expected that git-filter-branch aborts. But the test forgot\nto tell the branch name to rewrite, and so git-filter-branch failed due to\nincorrect usage.\n\nSigned-off-by: Johannes Sixt <johannes.sixt@telecom.at>\n---\n t/t7003-filter-branch.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t7003-filter-branch.sh b/t/t7003-filter-branch.sh\nindex 2089351..5f60b22 100755\n--- a/t/t7003-filter-branch.sh\n+++ b/t/t7003-filter-branch.sh\n@@ -114,7 +114,7 @@ test_expect_success 'use index-filter to move into a subdirectory' '\n \n test_expect_success 'stops when msg filter fails' '\n \told=$(git rev-parse HEAD) &&\n-\t! git-filter-branch -f --msg-filter false &&\n+\t! git-filter-branch -f --msg-filter false HEAD &&\n \ttest $old = $(git rev-parse HEAD) &&\n \trm -rf .git-rewrite\n '\n-- \n1.5.3.6.967.ga9b45\n"}]}