[PATCH] git-svn's dcommit must use subversion's config

Konstantin V. Arkhipov· Nov 14, 2007, 00:52 UTC · lore

When doing dcommit git-svn must use subversion's config or newly created files will not include svn's properties (defined in [auto-props] with 'enable-auto-props = yes').

Signed-off-by: Konstantin V. Arkhipov <voxus@onphp.org>
---
--- git-svn	2007-11-02 18:41:32.000000000 +0300
+++ git-svn	2007-11-12 19:35:44.000000000 +0300

Show changes to diff +3 −0

@@ -406,6 +406,9 @@ sub cmd_dcommit {
 			my %ed_opts = ( r => $last_rev,
 			                log => get_commit_entry($d)->{log},
 			                ra => Git::SVN::Ra->new($gs->full_url),
+			                config => SVN::Core::config_get_config(
+			                        $Git::SVN::Ra::config_dir
+			                ),
 			                tree_a => "$d~1",
 			                tree_b => $d,
 			                editor_cb => sub {

Eric Wong· Nov 17, 2007, 21:22 UTC · re: Konstantin V. Arkhipov · lore

Re: [PATCH] git-svn's dcommit must use subversion's config

"Konstantin V. Arkhipov" <voxus@onphp.org> wrote:

Show 5 quoted lines

> When doing dcommit git-svn must use subversion's config or newly created
> files will not include svn's properties
> (defined in [auto-props] with 'enable-auto-props = yes').
> 
> Signed-off-by: Konstantin V. Arkhipov <voxus@onphp.org>

> ---
> --- git-svn	2007-11-02 18:41:32.000000000 +0300
> +++ git-svn	2007-11-12 19:35:44.000000000 +0300

Thanks Konstantin,

I needed to add '.perl' to the filenames above to get the patch to apply. But otherwise,

Acked-by: Eric Wong <normalperson@yhbt.net>

Show 10 quoted lines

> @@ -406,6 +406,9 @@ sub cmd_dcommit {
>  			my %ed_opts = ( r => $last_rev,
>  			                log => get_commit_entry($d)->{log},
>  			                ra => Git::SVN::Ra->new($gs->full_url),
> +			                config => SVN::Core::config_get_config(
> +			                        $Git::SVN::Ra::config_dir
> +			                ),
>  			                tree_a => "$d~1",
>  			                tree_b => $d,
>  			                editor_cb => sub {

-- 
Eric Wong

patchgit-svn's dcommit must use subversion's config