# [PATCH] git-svn's dcommit must use subversion's config

2 messages from 2007-11-14 to 2007-11-17. Participants: Konstantin V. Arkhipov, Eric Wong.
Thread: https://gitlist.dev/t/10859

## Konstantin V. Arkhipov, 2007-11-14 00:52

Subject: [PATCH] git-svn's dcommit must use subversion's config
Message-ID: <200711140352.02978.voxus@onphp.org>
URL: https://gitlist.dev/e/200711140352.02978.voxus%40onphp.org

```
When doing dcommit git-svn must use subversion's config or newly created
files will not include svn's properties
(defined in [auto-props] with 'enable-auto-props = yes').

Signed-off-by: Konstantin V. Arkhipov <voxus@onphp.org>
---
--- git-svn	2007-11-02 18:41:32.000000000 +0300
+++ git-svn	2007-11-12 19:35:44.000000000 +0300
@@ -406,6 +406,9 @@ sub cmd_dcommit {
 			my %ed_opts = ( r => $last_rev,
 			                log => get_commit_entry($d)->{log},
 			                ra => Git::SVN::Ra->new($gs->full_url),
+			                config => SVN::Core::config_get_config(
+			                        $Git::SVN::Ra::config_dir
+			                ),
 			                tree_a => "$d~1",
 			                tree_b => $d,
 			                editor_cb => sub {

```

## Eric Wong, 2007-11-17 21:22

Subject: Re: [PATCH] git-svn's dcommit must use subversion's config
Message-ID: <20071117212241.GA22835@soma>
URL: https://gitlist.dev/e/20071117212241.GA22835%40soma
In-Reply-To: <200711140352.02978.voxus@onphp.org>

```
"Konstantin V. Arkhipov" <voxus@onphp.org> wrote:
> When doing dcommit git-svn must use subversion's config or newly created
> files will not include svn's properties
> (defined in [auto-props] with 'enable-auto-props = yes').
> 
> Signed-off-by: Konstantin V. Arkhipov <voxus@onphp.org>

> ---
> --- git-svn	2007-11-02 18:41:32.000000000 +0300
> +++ git-svn	2007-11-12 19:35:44.000000000 +0300

Thanks Konstantin,

I needed to add '.perl' to the filenames above to get the patch to
apply.  But otherwise,

Acked-by: Eric Wong <normalperson@yhbt.net>

> @@ -406,6 +406,9 @@ sub cmd_dcommit {
>  			my %ed_opts = ( r => $last_rev,
>  			                log => get_commit_entry($d)->{log},
>  			                ra => Git::SVN::Ra->new($gs->full_url),
> +			                config => SVN::Core::config_get_config(
> +			                        $Git::SVN::Ra::config_dir
> +			                ),
>  			                tree_a => "$d~1",
>  			                tree_b => $d,
>  			                editor_cb => sub {

-- 
Eric Wong

```
