threads / patch / 10436

patchRe: [PATCH] use only the PATH for exec'ing git commands

Subject: Re: [PATCH] use only the PATH for exec'ing git commands

## tl;dr

4 messages between Oct 22, 2007 and Oct 23, 2007. Diffs are folded; open one to read it.

replies: 3people: 4as markdown or json

Scott R Parish· Oct 22, 2007, 22:12 UTC · lore
Show 5 quoted lines
> Alex Riesen, Mon, Oct 22, 2007 12:01
> Scott R Parish, Mon, Oct 22, 2007 19:01:48 +0200:
> > +                strbuf_addch(out, ':');
>
> Shouldn't it break MingW32 native port?

What can i do here to better accommodate MingW32? You're right, just because the original code did it this way isn't a good excuse for me not to do it better.

sRp
Alex Riesen· Oct 22, 2007, 22:40 UTC · re: Scott R Parish · lore
Scott R Parish, Tue, Oct 23, 2007 00:12:02 +0200:
Show 9 quoted lines
> > Alex Riesen, Mon, Oct 22, 2007 12:01
> > Scott R Parish, Mon, Oct 22, 2007 19:01:48 +0200:
> > > +                strbuf_addch(out, ':');
> >
> > Shouldn't it break MingW32 native port?
> 
> What can i do here to better accommodate MingW32? You're
> right, just because the original code did it this way
> isn't a good excuse for me not to do it better.

someone here mentioned "higher abstractions". Maybe he meant moving the routines operating on path names and path lists out of the generic code into platform specific (like compat/). Maybe he was even going to do that himself, but I could be mistaken

Johannes Schindelin· Oct 22, 2007, 23:34 UTC · re: Alex Riesen · lore
Hi,
On Tue, 23 Oct 2007, Alex Riesen wrote:
Show 12 quoted lines
> Scott R Parish, Tue, Oct 23, 2007 00:12:02 +0200:
> > > Alex Riesen, Mon, Oct 22, 2007 12:01
> > > Scott R Parish, Mon, Oct 22, 2007 19:01:48 +0200:
> > > > +                strbuf_addch(out, ':');
> > >
> > > Shouldn't it break MingW32 native port?
> > 
> > What can i do here to better accommodate MingW32? You're right, just 
> > because the original code did it this way isn't a good excuse for me 
> > not to do it better.
> 
> someone here mentioned "higher abstractions".

That someone may well have mentioned that term, but what he meant was special case those code paths which have to be treated differently for Windows, and Windows alone.

(Yeah, I know, a response to that was that Nokia phones have drive letters, too, but that was an invalid objection to that particular statement, since Nokia phones expect the full path at any time, so I did not even bother answering to that mail. Well, in a way, I guess I just did.)

All this boils down to adding code dedicated to Windows. And I am a huge fan of the principle that you should cross bridges when you get to them, and not before (i.e. avoid over-engineering).

So my vote is: get it in as-is, us msysGit lot will cope with it in one way or another. (We already have at least one other place where ":" is used, which we have to cope with, in shell.c:do_cvs_command().)

Ciao, Dscho

Johannes Sixt· Oct 23, 2007, 06:14 UTC · re: Scott R Parish · lore
Scott R Parish schrieb:
Show 8 quoted lines
>> Alex Riesen, Mon, Oct 22, 2007 12:01
>> Scott R Parish, Mon, Oct 22, 2007 19:01:48 +0200:
>>> +                strbuf_addch(out, ':');
>> Shouldn't it break MingW32 native port?
> 
> What can i do here to better accommodate MingW32? You're
> right, just because the original code did it this way
> isn't a good excuse for me not to do it better.

Don't bother with it right now. GIT currently does not have MinGW specific code, yet.

-- Hannes

← back to recent threads