{"thread":{"id":"10436","subject":"Re: [PATCH] use only the PATH for exec'ing git commands","startedAt":"2007-10-22T22:12:02Z","lastAt":"2007-10-23T06:14:43Z","messageCount":4,"participants":["Scott R Parish","Alex Riesen","Johannes Schindelin","Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"56918","messageId":"1193091122.v2.fusewebmail-240137@f","threadId":"10436","inReplyTo":null,"subject":"Re: [PATCH] use only the PATH for exec'ing git commands","fromName":"Scott R Parish","fromEmail":"srp@srparish.net","sentAt":"2007-10-22T22:12:02Z","receivedAt":"2007-10-22T22:12:02Z","isPatch":true,"sender":{"key":"srp@srparish.net","avatar":"https://gravatar.com/avatar/870e5b6fc4f710cf4db5684bd9af7f2cee5734b3dab3209b13e00cf64f6c9f0e?d=mp&s=160"},"body":"> Alex Riesen, Mon, Oct 22, 2007 12:01\n> Scott R Parish, Mon, Oct 22, 2007 19:01:48 +0200:\n> > +                strbuf_addch(out, ':');\n>\n> Shouldn't it break MingW32 native port?\n\nWhat can i do here to better accommodate MingW32? You're\nright, just because the original code did it this way\nisn't a good excuse for me not to do it better.\n\nsRp\n"},{"id":"56919","messageId":"20071022224015.GG23714@steel.home","threadId":"10436","inReplyTo":"1193091122.v2.fusewebmail-240137@f","subject":"Re: [PATCH] use only the PATH for exec'ing git commands","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-10-22T22:40:15Z","receivedAt":"2007-10-22T22:40:15Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Scott R Parish, Tue, Oct 23, 2007 00:12:02 +0200:\n> > Alex Riesen, Mon, Oct 22, 2007 12:01\n> > Scott R Parish, Mon, Oct 22, 2007 19:01:48 +0200:\n> > > +                strbuf_addch(out, ':');\n> >\n> > Shouldn't it break MingW32 native port?\n> \n> What can i do here to better accommodate MingW32? You're\n> right, just because the original code did it this way\n> isn't a good excuse for me not to do it better.\n\nsomeone here mentioned \"higher abstractions\". Maybe he meant moving\nthe routines operating on path names and path lists out of the generic\ncode into platform specific (like compat/). Maybe he was even going to\ndo that himself, but I could be mistaken\n"},{"id":"56927","messageId":"Pine.LNX.4.64.0710230026380.25221@racer.site","threadId":"10436","inReplyTo":"20071022224015.GG23714@steel.home","subject":"Re: [PATCH] use only the PATH for exec'ing git commands","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-10-22T23:34:27Z","receivedAt":"2007-10-22T23:34:27Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 23 Oct 2007, Alex Riesen wrote:\n\n> Scott R Parish, Tue, Oct 23, 2007 00:12:02 +0200:\n> > > Alex Riesen, Mon, Oct 22, 2007 12:01\n> > > Scott R Parish, Mon, Oct 22, 2007 19:01:48 +0200:\n> > > > +                strbuf_addch(out, ':');\n> > >\n> > > Shouldn't it break MingW32 native port?\n> > \n> > What can i do here to better accommodate MingW32? You're right, just \n> > because the original code did it this way isn't a good excuse for me \n> > not to do it better.\n> \n> someone here mentioned \"higher abstractions\".\n\nThat someone may well have mentioned that term, but what he meant was \nspecial case those code paths which have to be treated differently for \nWindows, and Windows alone.\n\n(Yeah, I know, a response to that was that Nokia phones have drive \nletters, too, but that was an invalid objection to that particular \nstatement, since Nokia phones expect the full path at any time, so I did \nnot even bother answering to that mail.  Well, in a way, I guess I just \ndid.)\n\nAll this boils down to adding code dedicated to Windows.  And I am a huge \nfan of the principle that you should cross bridges when you get to them, \nand not before (i.e. avoid over-engineering).\n\nSo my vote is: get it in as-is, us msysGit lot will cope with it in one \nway or another.  (We already have at least one other place where \":\" is \nused, which we have to cope with, in shell.c:do_cvs_command().)\n\nCiao,\nDscho\n"},{"id":"56980","messageId":"471D9153.30109@viscovery.net","threadId":"10436","inReplyTo":"1193091122.v2.fusewebmail-240137@f","subject":"Re: [PATCH] use only the PATH for exec'ing git commands","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2007-10-23T06:14:43Z","receivedAt":"2007-10-23T06:14:43Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Scott R Parish schrieb:\n>> Alex Riesen, Mon, Oct 22, 2007 12:01\n>> Scott R Parish, Mon, Oct 22, 2007 19:01:48 +0200:\n>>> +                strbuf_addch(out, ':');\n>> Shouldn't it break MingW32 native port?\n> \n> What can i do here to better accommodate MingW32? You're\n> right, just because the original code did it this way\n> isn't a good excuse for me not to do it better.\n\nDon't bother with it right now. GIT currently does not have MinGW specific \ncode, yet.\n\n-- Hannes\n"}]}