Re: [PATCH] Deduce exec_path also from calls to git with a relative path

Scott R Parish· Oct 20, 2007, 08:13 UTC · lore

Wow, that sure cleaned up nicely! :)

Thanks sRp

----- Original Message -----
Subject: [PATCH] Deduce exec_path also from calls to git with a relative path
Date: Sat, October 20, 2007 0:21
From: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>

Show 57 quoted lines

> There is already logic in the git wrapper to deduce the exec_path from
> argv[0], when the git wrapper was called with an absolute path.  Extend
> that logic to handle relative paths as well.
>
> For example, when you call "../../hello/world/git", it will not turn
> "../../hello/world" into an absolute path, and use that.
>
> Initial implementation by Scott R Parish.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>
>         On Fri, 19 Oct 2007, Scott R Parish wrote:
>
>         >  Signed-off-by: Scott R Parish <srp@srparish.net>
>
>         That is a little short for a commit message ;-)
>
>         >  git.c |   35 +++++++++++++++++++++++++++++++++--
>         >  1 files changed, 33 insertions(+), 2 deletions(-)
>
>         I had commented on this before.  Probably I did a very bad job
>         at explaining things, so hopefully this is better:
>
>  git.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/git.c b/git.c
> index d7c6bca..1dad764 100644
> --- a/git.c
> +++ b/git.c
> @@ -414,13 +414,14 @@ int main(int argc, const char **argv)
>          /*
>           * Take the basename of argv[0] as the command
>           * name, and the dirname as the default exec_path
> -         * if it's an absolute path and we don't have
> -         * anything better.
> +         * if we don't have anything better.
>           */
>          if (slash) {
>                  *slash++ = 0;
>                  if (*cmd == '/')
>                          exec_path = cmd;
> +                else
> +                        exec_path = xstrdup(make_absolute_path(cmd));
>                  cmd = slash;
>          }
>
> --
> 1.5.3.4.1287.g8b31e
>
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>

Johannes Schindelin· Oct 20, 2007, 21:31 UTC · re: Scott R Parish · lore

Hi,

On Sat, 20 Oct 2007, Scott R Parish wrote:

> Wow, that sure cleaned up nicely! :)

Heh.

BTW I did not mean to discourage you... Rather, I wanted to show you that this list is a wonderful place to learn, as I did, do, and will do many times here. (Just to clarify, since somebody said that I am usually not nice to newbies... cannot understand that at all ;-)

Ciao, Dscho

Scott Parish· Oct 20, 2007, 23:04 UTC · re: Johannes Schindelin · lore

On Sat, Oct 20, 2007 at 10:31:47PM +0100, Johannes Schindelin wrote:

> BTW I did not mean to discourage you...  Rather, I wanted to show you that 
> this list is a wonderful place to learn, as I did, do, and will do many 
> times here.  (Just to clarify, since somebody said that I am usually not 
> nice to newbies... cannot understand that at all ;-)

Nah, i'm actually rather encouraged that people have shown interest in my patches and are so quick to find ways to improve on them!

Sorry about the top posting earlier; i've been away from active open source participation for a while and have been forgetting my etiquette.

sRp

-- 
Scott Parish
http://srparish.net/

patchRe: [PATCH] Deduce exec_path also from calls to git with a relative path