{"thread":{"id":"10391","subject":"Re: [PATCH] Deduce exec_path also from calls to git with a relative path","startedAt":"2007-10-20T08:13:26Z","lastAt":"2007-10-20T23:04:15Z","messageCount":3,"participants":["Scott R Parish","Johannes Schindelin","Scott Parish"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"56680","messageId":"1192868006.v2.fusewebmail-240137@f","threadId":"10391","inReplyTo":null,"subject":"Re: [PATCH] Deduce exec_path also from calls to git with a relative path","fromName":"Scott R Parish","fromEmail":"srp@srparish.net","sentAt":"2007-10-20T08:13:26Z","receivedAt":"2007-10-20T08:13:26Z","isPatch":true,"sender":{"key":"srp@srparish.net","avatar":"https://gravatar.com/avatar/870e5b6fc4f710cf4db5684bd9af7f2cee5734b3dab3209b13e00cf64f6c9f0e?d=mp&s=160"},"body":"\nWow, that sure cleaned up nicely! :)\n\nThanks\nsRp\n\n\n----- Original Message -----\nSubject: [PATCH] Deduce exec_path also from calls to git with a relative path\nDate: Sat, October 20, 2007 0:21\nFrom: \"Johannes Schindelin\" \n\n> There is already logic in the git wrapper to deduce the exec_path from\n> argv[0], when the git wrapper was called with an absolute path. Extend\n> that logic to handle relative paths as well.\n>\n> For example, when you call \"../../hello/world/git\", it will not turn\n> \"../../hello/world\" into an absolute path, and use that.\n>\n> Initial implementation by Scott R Parish.\n>\n> Signed-off-by: Johannes Schindelin \n> ---\n>\n> On Fri, 19 Oct 2007, Scott R Parish wrote:\n>\n> > Signed-off-by: Scott R Parish \n>\n> That is a little short for a commit message ;-)\n>\n> > git.c | 35 +++++++++++++++++++++++++++++++++--\n> > 1 files changed, 33 insertions(+), 2 deletions(-)\n>\n> I had commented on this before. Probably I did a very bad job\n> at explaining things, so hopefully this is better:\n>\n> git.c | 5 +++--\n> 1 files changed, 3 insertions(+), 2 deletions(-)\n>\n> diff --git a/git.c b/git.c\n> index d7c6bca..1dad764 100644\n> --- a/git.c\n> +++ b/git.c\n> @@ -414,13 +414,14 @@ int main(int argc, const char **argv)\n> /*\n> * Take the basename of argv[0] as the command\n> * name, and the dirname as the default exec_path\n> - * if it's an absolute path and we don't have\n> - * anything better.\n> + * if we don't have anything better.\n> */\n> if (slash) {\n> *slash++ = 0;\n> if (*cmd == '/')\n> exec_path = cmd;\n> + else\n> + exec_path = xstrdup(make_absolute_path(cmd));\n> cmd = slash;\n> }\n>\n> --\n> 1.5.3.4.1287.g8b31e\n>\n> -\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n>\n>\n"},{"id":"56720","messageId":"Pine.LNX.4.64.0710202225520.25221@racer.site","threadId":"10391","inReplyTo":"1192868006.v2.fusewebmail-240137@f","subject":"Re: [PATCH] Deduce exec_path also from calls to git with a relative path","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-10-20T21:31:47Z","receivedAt":"2007-10-20T21:31:47Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 20 Oct 2007, Scott R Parish wrote:\n\n> Wow, that sure cleaned up nicely! :)\n\nHeh.\n\nBTW I did not mean to discourage you... Rather, I wanted to show you that \nthis list is a wonderful place to learn, as I did, do, and will do many \ntimes here. (Just to clarify, since somebody said that I am usually not \nnice to newbies... cannot understand that at all ;-)\n\nCiao,\nDscho\n"},{"id":"56729","messageId":"20071020230414.GB16291@srparish.net","threadId":"10391","inReplyTo":"Pine.LNX.4.64.0710202225520.25221@racer.site","subject":"Re: [PATCH] Deduce exec_path also from calls to git with a relative path","fromName":"Scott Parish","fromEmail":"srp@srparish.net","sentAt":"2007-10-20T23:04:15Z","receivedAt":"2007-10-20T23:04:15Z","isPatch":true,"sender":{"key":"srp@srparish.net","avatar":"https://gravatar.com/avatar/870e5b6fc4f710cf4db5684bd9af7f2cee5734b3dab3209b13e00cf64f6c9f0e?d=mp&s=160"},"body":"On Sat, Oct 20, 2007 at 10:31:47PM +0100, Johannes Schindelin wrote:\n\n> BTW I did not mean to discourage you... Rather, I wanted to show you that \n> this list is a wonderful place to learn, as I did, do, and will do many \n> times here. (Just to clarify, since somebody said that I am usually not \n> nice to newbies... cannot understand that at all ;-)\n\nNah, i'm actually rather encouraged that people have shown interest\nin my patches and are so quick to find ways to improve on them!\n\nSorry about the top posting earlier; i've been away from active\nopen source participation for a while and have been forgetting my\netiquette.\n\nsRp\n\n-- \nScott Parish\nhttp://srparish.net/\n"}]}