threads / discuss / 1033

new features in gitk

Subject: new features in gitk

## tl;dr

8 messages between Jun 27, 2005 and Jun 30, 2005.

replies: 7people: 5as markdown or json

Paul Mackerras· Jun 27, 2005, 22:22 UTC · lore
New features that I have added recently to the gitk repository at
rsync://rsync.kernel.org/pub/scm/gitk/gitk.git
include:
* Added a right-click context menu on the headlines displayed in the
  top-left pane with the following entries:
  - Display diff between two commits
  - Generate a patch file containing the diff between two commits
  - Create a local direct tag for a commit
* Left-click on a graph line now displays the parent and the children
  connected by that line in the bottom-left pane, with buttons
  allowing you to jump to the parent or a child.
* Pasting into the SHA1 ID field clears it first if it already
  contains a SHA1 ID.
* Checks for a .git (or $GIT_DIR) directory at startup.

I'm interested to know if people find the diff/patch generation options useful.

Paul.
Luc Van Oostenryck· Jun 27, 2005, 22:49 UTC · re: Paul Mackerras · lore

Re: new features in gitk

Paul Mackerras wrote:
Show 5 quoted lines
> 
> I'm interested to know if people find the diff/patch generation
> options useful.
> 
> Paul.

I find the patch generation very usefull (when I've seen the tool a few days ago, I've said to myself: "what a wonderfull tool, if only I could create a patch from this") but it doesn't work for me (the first three entries stay always in grey, only the last one "Create tag" is in black). I'm missing something ?

Luc
Paul Mackerras· Jun 27, 2005, 23:36 UTC · re: Luc Van Oostenryck · lore

Re: new features in gitk

Luc Van Oostenryck writes:
> I find the patch generation very usefull (when I've seen the tool a few days ago, I've said to myself:
> "what a wonderfull tool, if only I could create a patch from this")
> but it doesn't work for me (the first three entries stay always in grey, only the last one "Create tag" is in black).
> I'm missing something ?

The diffs and patches are between the selected commit (one that you clicked on with the left button and which is shown with a grey background) and the commit where you click the right button. That was the best way I could think of to indicate which were the two commits to diff. If you (or anyone) has a better suggestion, let me know.

Paul.
Luc Van Oostenryck· Jun 28, 2005, 20:24 UTC · re: Paul Mackerras · lore

Re: new features in gitk

Paul Mackerras wrote:
Show 16 quoted lines
> Luc Van Oostenryck writes:
> 
> 
>>I find the patch generation very usefull (when I've seen the tool a few days ago, I've said to myself:
>>"what a wonderfull tool, if only I could create a patch from this")
>>but it doesn't work for me (the first three entries stay always in grey, only the last one "Create tag" is in black).
>>I'm missing something ?
> 
> 
> The diffs and patches are between the selected commit (one that you
> clicked on with the left button and which is shown with a grey
> background) and the commit where you click the right button.  That was
> the best way I could think of to indicate which were the two commits
> to diff.  If you (or anyone) has a better suggestion, let me know.
> 
> Paul.

OK I see it now, it works nicely. I didn't found the tric yesterday because I was thinking: one commit -> one patch, but it's probably more usefull like it is now.

Thanks.
Linus Torvalds· Jun 28, 2005, 01:21 UTC · re: Paul Mackerras · lore

Re: new features in gitk

On Tue, 28 Jun 2005, Paul Mackerras wrote:
>
> New features that I have added recently to the gitk repository at
Hey, cool, the automatic merge actually worked.

I knew it would, of course, but still.. It's nice when theory and practice end up matching.

		Linus
Greg KH· Jun 28, 2005, 06:22 UTC · re: Paul Mackerras · lore

Re: new features in gitk

On Tue, Jun 28, 2005 at 08:22:46AM +1000, Paul Mackerras wrote:
> I'm interested to know if people find the diff/patch generation
> options useful.

Well, I find them nice to have, in case I need to generate a real patch. Nice job.

thanks,
greg k-h
Junio C Hamano· Jun 30, 2005, 06:20 UTC · re: Paul Mackerras · lore

Re: new features in gitk

Finally I started converting my workflow of day-job I do on my home machine from darcs to git, so I started running cvs2git over ssh slurping from my office environment (sloooooooooow).

While I was watching the import going, I started up gitk on the halfway imported repository, and it showed Japanese characters in the source correctly without any special configuration (the only thing I have is LC_CTYPE=ja_JP). Very often GUIish software would not work properly for me with Japanese characters, and this was a pleasant surprise.

The credit is probably owed more to tk, not something you do special in gitk, but nevertheless I am impressed and happy ;-).

← back to recent threads