# new features in gitk 8 messages from 2005-06-27 to 2005-06-30. Participants: Paul Mackerras, Luc Van Oostenryck, Linus Torvalds, Greg KH, Junio C Hamano. Thread: https://gitlist.dev/t/1033 ## Paul Mackerras, 2005-06-27 22:22 Subject: new features in gitk Message-ID: <17088.31798.17291.605567@cargo.ozlabs.ibm.com> URL: https://gitlist.dev/e/17088.31798.17291.605567%40cargo.ozlabs.ibm.com ``` New features that I have added recently to the gitk repository at rsync://rsync.kernel.org/pub/scm/gitk/gitk.git include: * Added a right-click context menu on the headlines displayed in the top-left pane with the following entries: - Display diff between two commits - Generate a patch file containing the diff between two commits - Create a local direct tag for a commit * Left-click on a graph line now displays the parent and the children connected by that line in the bottom-left pane, with buttons allowing you to jump to the parent or a child. * Pasting into the SHA1 ID field clears it first if it already contains a SHA1 ID. * Checks for a .git (or $GIT_DIR) directory at startup. I'm interested to know if people find the diff/patch generation options useful. Paul. ``` ## Luc Van Oostenryck, 2005-06-27 22:49 Subject: Re: new features in gitk Message-ID: <42C08265.2050209@looxix.net> URL: https://gitlist.dev/e/42C08265.2050209%40looxix.net In-Reply-To: <17088.31798.17291.605567@cargo.ozlabs.ibm.com> ``` Paul Mackerras wrote: > > I'm interested to know if people find the diff/patch generation > options useful. > > Paul. I find the patch generation very usefull (when I've seen the tool a few days ago, I've said to myself: "what a wonderfull tool, if only I could create a patch from this") but it doesn't work for me (the first three entries stay always in grey, only the last one "Create tag" is in black). I'm missing something ? Luc ``` ## Paul Mackerras, 2005-06-27 23:36 Subject: Re: new features in gitk Message-ID: <17088.36232.479492.643878@cargo.ozlabs.ibm.com> URL: https://gitlist.dev/e/17088.36232.479492.643878%40cargo.ozlabs.ibm.com In-Reply-To: <42C08265.2050209@looxix.net> ``` Luc Van Oostenryck writes: > I find the patch generation very usefull (when I've seen the tool a few days ago, I've said to myself: > "what a wonderfull tool, if only I could create a patch from this") > but it doesn't work for me (the first three entries stay always in grey, only the last one "Create tag" is in black). > I'm missing something ? The diffs and patches are between the selected commit (one that you clicked on with the left button and which is shown with a grey background) and the commit where you click the right button. That was the best way I could think of to indicate which were the two commits to diff. If you (or anyone) has a better suggestion, let me know. Paul. ``` ## Linus Torvalds, 2005-06-28 01:21 Subject: Re: new features in gitk Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.58.0506271819180.19755%40ppc970.osdl.org In-Reply-To: <17088.31798.17291.605567@cargo.ozlabs.ibm.com> ``` On Tue, 28 Jun 2005, Paul Mackerras wrote: > > New features that I have added recently to the gitk repository at Hey, cool, the automatic merge actually worked. I knew it would, of course, but still.. It's nice when theory and practice end up matching. Linus ``` ## Greg KH, 2005-06-28 06:22 Subject: Re: new features in gitk Message-ID: <20050628062256.GA2555@kroah.com> URL: https://gitlist.dev/e/20050628062256.GA2555%40kroah.com In-Reply-To: <17088.31798.17291.605567@cargo.ozlabs.ibm.com> ``` On Tue, Jun 28, 2005 at 08:22:46AM +1000, Paul Mackerras wrote: > I'm interested to know if people find the diff/patch generation > options useful. Well, I find them nice to have, in case I need to generate a real patch. Nice job. thanks, greg k-h ``` ## Luc Van Oostenryck, 2005-06-28 20:24 Subject: Re: new features in gitk Message-ID: <42C1B20D.2000502@looxix.net> URL: https://gitlist.dev/e/42C1B20D.2000502%40looxix.net In-Reply-To: <17088.36232.479492.643878@cargo.ozlabs.ibm.com> ``` Paul Mackerras wrote: > Luc Van Oostenryck writes: > > >>I find the patch generation very usefull (when I've seen the tool a few days ago, I've said to myself: >>"what a wonderfull tool, if only I could create a patch from this") >>but it doesn't work for me (the first three entries stay always in grey, only the last one "Create tag" is in black). >>I'm missing something ? > > > The diffs and patches are between the selected commit (one that you > clicked on with the left button and which is shown with a grey > background) and the commit where you click the right button. That was > the best way I could think of to indicate which were the two commits > to diff. If you (or anyone) has a better suggestion, let me know. > > Paul. OK I see it now, it works nicely. I didn't found the tric yesterday because I was thinking: one commit -> one patch, but it's probably more usefull like it is now. Thanks. ``` ## Paul Mackerras, 2005-06-28 23:41 Subject: Re: new features in gitk Message-ID: <17089.57407.401624.981660@cargo.ozlabs.ibm.com> URL: https://gitlist.dev/e/17089.57407.401624.981660%40cargo.ozlabs.ibm.com In-Reply-To: ``` Linus Torvalds writes: > Hey, cool, the automatic merge actually worked. Yes, very cool. It'll get more interesting if you make changes to gitk in your repository, of course. :) Paul. ``` ## Junio C Hamano, 2005-06-30 06:20 Subject: Re: new features in gitk Message-ID: <7vd5q45psq.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vd5q45psq.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <17088.31798.17291.605567@cargo.ozlabs.ibm.com> ``` Finally I started converting my workflow of day-job I do on my home machine from darcs to git, so I started running cvs2git over ssh slurping from my office environment (sloooooooooow). While I was watching the import going, I started up gitk on the halfway imported repository, and it showed Japanese characters in the source correctly without any special configuration (the only thing I have is LC_CTYPE=ja_JP). Very often GUIish software would not work properly for me with Japanese characters, and this was a pleasant surprise. The credit is probably owed more to tk, not something you do special in gitk, but nevertheless I am impressed and happy ;-). ```