Git-tag's over-aggressive pipework fails badly on fresh Ubuntu, over NFS.

Samium Gromoff· Sep 25, 2007, 22:34 UTC · lore

Hello folks,

Without the following applied, git-tag -s gets zeroes into TAG_TMP in place of the .asc sig, resulting in an unsigned commit.

My repository is located on a NFS share, and I didn't check with NFS factored out, so it might be more extensive.

I'm not sure what's the policy -- "go and fix Ubuntu, your filesystem and your kernel", or "let's go the safe way", so there it is.

--- a/git-tag   2007-09-07 22:12:11.000000000 +0400
+++ b/git-tag   2007-09-26 02:19:42.000000000 +0400
@@ -143,7 +143,8 @@
     rm -f "$GIT_DIR"/TAG_TMP.asc "$GIT_DIR"/TAG_FINALMSG
     if [ "$signed" ]; then
        gpg -bsa -u "$username" "$GIT_DIR"/TAG_TMP &&
-       cat "$GIT_DIR"/TAG_TMP.asc >>"$GIT_DIR"/TAG_TMP ||
+       cat "$GIT_DIR"/TAG_TMP "$GIT_DIR"/TAG_TMP.asc > "$GIT_DIR"/TAG_TMP_RELAY &&
+       mv "$GIT_DIR"/TAG_TMP_RELAY "$GIT_DIR"/TAG_TMP ||
        die "failed to sign the tag with GPG."
     fi
     object=$(git-mktag < "$GIT_DIR"/TAG_TMP)

Git is 1.5.2.5-2build1/Gutsy.

regards, Samium Gromoff

Johannes Schindelin· Sep 25, 2007, 23:01 UTC · re: Samium Gromoff · lore

Re: Git-tag's over-aggressive pipework fails badly on fresh Ubuntu, over NFS.

Hi,

On Wed, 26 Sep 2007, Samium Gromoff wrote:

> Without the following applied, git-tag -s gets zeroes into TAG_TMP
> in place of the .asc sig, resulting in an unsigned commit.

You'll be delighted to hear that it is no longer necessary to patch git-tag.sh (git-tag is not the right place), since git-tag is now a builtin (without much in the way of pipes...)

Ciao, Dscho