{"thread":{"id":"10020","subject":"Git-tag's over-aggressive pipework fails badly on fresh Ubuntu, over NFS.","startedAt":"2007-09-25T22:34:25Z","lastAt":"2007-09-25T23:01:18Z","messageCount":2,"participants":["Samium Gromoff","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"54055","messageId":"87hclifk7i.wl@betelheise.deep.net","threadId":"10020","inReplyTo":null,"subject":"Git-tag's over-aggressive pipework fails badly on fresh Ubuntu, over NFS.","fromName":"Samium Gromoff","fromEmail":"_deepfire@feelingofgreen.ru","sentAt":"2007-09-25T22:34:25Z","receivedAt":"2007-09-25T22:34:25Z","isPatch":false,"sender":{"key":"_deepfire@feelingofgreen.ru","avatar":"https://gravatar.com/avatar/d68b7e638272cedce7a897a0fdbe7296ebb1db2cbecaff5b1763c27c94c72940?d=mp&s=160"},"body":"Hello folks,\n\nWithout the following applied, git-tag -s gets zeroes into TAG_TMP\nin place of the .asc sig, resulting in an unsigned commit.\n\nMy repository is located on a NFS share, and I didn't check with NFS factored\nout, so it might be more extensive.\n\nI'm not sure what's the policy -- \"go and fix Ubuntu, your filesystem\nand your kernel\", or \"let's go the safe way\", so there it is.\n\n--- a/git-tag   2007-09-07 22:12:11.000000000 +0400\n+++ b/git-tag   2007-09-26 02:19:42.000000000 +0400\n@@ -143,7 +143,8 @@\n     rm -f \"$GIT_DIR\"/TAG_TMP.asc \"$GIT_DIR\"/TAG_FINALMSG\n     if [ \"$signed\" ]; then\n        gpg -bsa -u \"$username\" \"$GIT_DIR\"/TAG_TMP &&\n-       cat \"$GIT_DIR\"/TAG_TMP.asc >>\"$GIT_DIR\"/TAG_TMP ||\n+       cat \"$GIT_DIR\"/TAG_TMP \"$GIT_DIR\"/TAG_TMP.asc > \"$GIT_DIR\"/TAG_TMP_RELAY &&\n+       mv \"$GIT_DIR\"/TAG_TMP_RELAY \"$GIT_DIR\"/TAG_TMP ||\n        die \"failed to sign the tag with GPG.\"\n     fi\n     object=$(git-mktag < \"$GIT_DIR\"/TAG_TMP)\n\nGit is 1.5.2.5-2build1/Gutsy.\n\nregards, Samium Gromoff\n"},{"id":"54059","messageId":"Pine.LNX.4.64.0709260000340.28395@racer.site","threadId":"10020","inReplyTo":"87hclifk7i.wl@betelheise.deep.net","subject":"Re: Git-tag's over-aggressive pipework fails badly on fresh Ubuntu, over NFS.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-09-25T23:01:18Z","receivedAt":"2007-09-25T23:01:18Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 26 Sep 2007, Samium Gromoff wrote:\n\n> Without the following applied, git-tag -s gets zeroes into TAG_TMP\n> in place of the .asc sig, resulting in an unsigned commit.\n\nYou'll be delighted to hear that it is no longer necessary to patch \ngit-tag.sh (git-tag is not the right place), since git-tag is now a \nbuiltin (without much in the way of pipes...)\n\nCiao,\nDscho\n"}]}