git repo structure reports statistics on everything in a repository, which is useful for diagnosing performance problems from large objects. Mark C. Chu-Carroll's patch aims to let users focus on part of a repository. An earlier version added flags to exclude reference types. The current version accepts rev expressions to filter the set of objects processed, and with no revisions it covers everything as before.

The implementation uses setup_revisions. Mark's description says this involves an awkward trade-off: the ref walk is done twice when revisions are given on the command line.

Junio C Hamano asked whether the project is willing to lose "--" from the command line. For example, git repo structure master..grobble -- t/ might be useful, but without PARSE_OPT_KEEP_DASHDASH the "--" would be lost. Users need it to disambiguate paths that share a name with a revision. He noted that arguments such as --objects, --stdin and --end-of-options would still cause setup_revisions() to be called.

Junio also said that hardcoding .disk_size in tests makes them brittle, since zlib implementations differ. Mark replied that for now he will put the affected tests under the SHA1 prerequisite and later update all the tests in the file to remove that prerequisite.

The parsing question has no answer in the excerpts.